Powershell: Install-CFFeatures handles IAAS conditionality

Author: aramprice

modules/BOSH.CFCell/BOSH.CFCell.Tests.ps1

@@ -67,36 +67,48 @@ Describe "Install-CFFeatures" {
         Mock -ModuleName BOSH.CFCell Write-Log { }
         Mock -ModuleName BOSH.CFCell Get-WinRMConfig { "Some config" }
         Mock -ModuleName BOSH.CFCell WindowsFeatureInstall { }
-        Mock Uninstall-WindowsFeature { }
         Mock -ModuleName BOSH.CFCell Uninstall-WindowsFeature { }
         Mock -ModuleName BOSH.CFCell Set-Service { }
         Mock -ModuleName BOSH.CFCell Restart-Computer { }
-        Mock -ModuleName BOSH.CFCell Get-OSVersionString { "10.0.1803" }
     }
 
     It "triggers a machine restart when the -ForceReboot flag is set" {
-        { Install-CFFeatures -IaaS "ignored" -ForceReboot } | Should -Not -Throw
+        { Install-CFFeatures -IaaS "not-vsphere" -ForceReboot } | Should -Not -Throw
 
         Assert-MockCalled Restart-Computer -Times 1 -Scope It -ModuleName BOSH.CFCell
     }
 
     It "doesn't trigger a machine restart if -ForceReboot flag not set" {
-        { Install-CFFeatures -IaaS "ignored" } | Should -Not -Throw
+        { Install-CFFeatures -IaaS "not-vsphere" } | Should -Not -Throw
 
         Assert-MockCalled Restart-Computer -Times 0 -Scope It -ModuleName BOSH.CFCell
     }
 
     It "logs Installing CloudFoundry Cell Windows Features" {
-        { Install-CFFeatures -IaaS "ignored" } | Should -Not -Throw
+        { Install-CFFeatures -IaaS "not-vsphere" } | Should -Not -Throw
 
         Assert-MockCalled Write-Log -Times 1 -Scope It -ModuleName BOSH.CFCell -ParameterFilter { $Message -eq "Installing CloudFoundry Cell Windows Features" }
     }
 
     It "logs Installed CloudFoundry Cell Windows Features after installation" {
-        { Install-CFFeatures -IaaS "ignored" } | Should -Not -Throw
+        { Install-CFFeatures -IaaS "not-vsphere" } | Should -Not -Throw
 
         Assert-MockCalled Write-Log -Times 1 -Scope It -ModuleName BOSH.CFCell -ParameterFilter { $Message -eq "Installed CloudFoundry Cell Windows Features" }
     }
+
+    It "calls Uninstall-WindowsFeature (for '*Defender')" {
+        { Install-CFFeatures -IaaS "not-vsphere" } | Should -Not -Throw
+
+        Should -Invoke -ModuleName BOSH.CFCell -CommandName Uninstall-WindowsFeature
+    }
+
+    Context "when -IaaS is 'vsphere'" {
+        It "does not call Uninstall-WindowsFeature (for '*Defender')" {
+            { Install-CFFeatures -IaaS "vsphere" } | Should -Not -Throw
+
+            Should -Not -Invoke -ModuleName BOSH.CFCell -CommandName Uninstall-WindowsFeature
+        }
+    }
 }
 
 Describe "Remove-DockerPackage" {

modules/BOSH.CFCell/BOSH.CFCell.psm1

@@ -20,8 +20,9 @@ function Install-CFFeatures {
 
   WindowsFeatureInstall("FS-Resource-Manager")
   WindowsFeatureInstall("Containers")
-  Get-WindowsFeature | Where-Object -FilterScript { $_.Name -like '*Defender*' } | Uninstall-WindowsFeature -Remove
-
+  if ($IaaS -ne "vsphere") {
+      Get-WindowsFeature | Where-Object -FilterScript { $_.Name -like '*Defender*' } | Uninstall-WindowsFeature -Remove
+  }
   Write-Log "Installed CloudFoundry Cell Windows Features"
 
   Write-Log "Setting WinRM startup type to automatic"

stembuild/modules/BOSH.CFCell/BOSH.CFCell.Tests.ps1

@@ -100,36 +100,48 @@ Describe "Install-CFFeatures" {
         Mock -ModuleName BOSH.CFCell Write-Log { }
         Mock -ModuleName BOSH.CFCell Get-WinRMConfig { "Some config" }
         Mock -ModuleName BOSH.CFCell WindowsFeatureInstall { }
-        Mock Uninstall-WindowsFeature { }
         Mock -ModuleName BOSH.CFCell Uninstall-WindowsFeature { }
         Mock -ModuleName BOSH.CFCell Set-Service { }
         Mock -ModuleName BOSH.CFCell Restart-Computer { }
-        Mock -ModuleName BOSH.CFCell Get-OSVersionString { "10.0.1803" }
     }
 
     It "triggers a machine restart when the -ForceReboot flag is set" {
-        { Install-CFFeatures -IaaS "ignored" -ForceReboot } | Should -Not -Throw
+        { Install-CFFeatures -IaaS "not-vsphere" -ForceReboot } | Should -Not -Throw
 
         Assert-MockCalled Restart-Computer -Times 1 -Scope It -ModuleName BOSH.CFCell
     }
 
     It "doesn't trigger a machine restart if -ForceReboot flag not set" {
-        { Install-CFFeatures -IaaS "ignored" } | Should -Not -Throw
+        { Install-CFFeatures -IaaS "not-vsphere" } | Should -Not -Throw
 
         Assert-MockCalled Restart-Computer -Times 0 -Scope It -ModuleName BOSH.CFCell
     }
 
     It "logs Installing CloudFoundry Cell Windows Features" {
-        { Install-CFFeatures -IaaS "ignored" } | Should -Not -Throw
+        { Install-CFFeatures -IaaS "not-vsphere" } | Should -Not -Throw
 
         Assert-MockCalled Write-Log -Times 1 -Scope It -ModuleName BOSH.CFCell -ParameterFilter { $Message -eq "Installing CloudFoundry Cell Windows Features" }
     }
 
     It "logs Installed CloudFoundry Cell Windows Features after installation" {
-        { Install-CFFeatures -IaaS "ignored" } | Should -Not -Throw
+        { Install-CFFeatures -IaaS "not-vsphere" } | Should -Not -Throw
 
         Assert-MockCalled Write-Log -Times 1 -Scope It -ModuleName BOSH.CFCell -ParameterFilter { $Message -eq "Installed CloudFoundry Cell Windows Features" }
     }
+
+    It "calls Uninstall-WindowsFeature (for '*Defender')" {
+        { Install-CFFeatures -IaaS "not-vsphere" } | Should -Not -Throw
+
+        Should -Invoke -ModuleName BOSH.CFCell -CommandName Uninstall-WindowsFeature
+    }
+
+    Context "when -IaaS is 'vsphere'" {
+        It "does not call Uninstall-WindowsFeature (for '*Defender')" {
+            { Install-CFFeatures -IaaS "vsphere" } | Should -Not -Throw
+
+            Should -Not -Invoke -ModuleName BOSH.CFCell -CommandName Uninstall-WindowsFeature
+        }
+    }
 }
 
 Describe "Remove-DockerPackage" {

stembuild/modules/BOSH.CFCell/BOSH.CFCell.psm1

@@ -20,7 +20,9 @@ function Install-CFFeatures {
 
   WindowsFeatureInstall("FS-Resource-Manager")
   WindowsFeatureInstall("Containers")
-
+  if ($IaaS -ne "vsphere") {
+      Get-WindowsFeature | Where-Object -FilterScript { $_.Name -like '*Defender*' } | Uninstall-WindowsFeature -Remove
+  }
   Write-Log "Installed CloudFoundry Cell Windows Features"
 
   Write-Log "Setting WinRM startup type to automatic"