OpenSSH: install as part of VM setup, not WinRM

It appears that executing `Add-WindowsCapability` via WinRM is not
viable, this commit moves the installation of OpenSSH.Server to the
various IaaS pre-boot scrips which are not executed via WinRM.

The installation of OpenSSSH.Server was added as follows:

Azure: add a `custom_script` parameter to packer config
AWS: added to `setup_winrm.txt`
GCP: add to `setup-winrm.ps1` and use `sysprep-specialize-script-ps1`

Author: aramprice

lib/packer/config/azure.rb

@@ -45,7 +45,8 @@ def builders
                 'winrm_use_ssl' => 'true',
                 'winrm_insecure' => 'true',
                 'winrm_timeout' => '1h',
-                'winrm_username' => 'packer'
+                'winrm_username' => 'packer',
+                'custom_script' => 'powershell -ExecutionPolicy Unrestricted -NoProfile -NonInteractive -Command "Add-WindowsCapability -Online -Name (Get-WindowsCapability -Online -Name OpenSSH.Server* | ForEach-Object Name)"'
             }
         ]
       end

lib/packer/config/gcp.rb

@@ -39,6 +39,7 @@ def initialize(
       end
 
       def builders
+        stemcell_builder_dir = File.expand_path('../../../../', __FILE__)
         [
           {
             'type' => 'googlecompute',
@@ -62,7 +63,7 @@ def builders
             'winrm_timeout' => '1h',
             'state_timeout' => '10m',
             'metadata' => {
-              'sysprep-specialize-script-url' => 'https://raw.githubusercontent.com/cloudfoundry/bosh-windows-stemcell-builder/master/scripts/gcp/setup-winrm.ps1',
+              'sysprep-specialize-script-ps1' => File.read(File.join(stemcell_builder_dir, 'scripts', 'gcp', 'setup-winrm.ps1')),
               'name' => "#{@vm_prefix}-#{Time.now.to_i}",
             }.compact_blank!
           }

scripts/aws/setup_winrm.txt

@@ -34,5 +34,10 @@ if (-not (Get-Command Enable-WinRM -errorAction SilentlyContinue))
 Write-Log "Invoking WinRM"
 Enable-WinRM
 
+Write-Log "Install OpenSSH.Server"
+Write-Log (Get-WindowsCapability -Online -Name "OpenSSH.Server*" | Format-List | Out-String)
+Add-WindowsCapability -Online -Name (Get-WindowsCapability -Online -Name "OpenSSH.Server*" | ForEach-Object Name)
+Write-Log (Get-WindowsCapability -Online -Name "OpenSSH.Server*" | Format-List | Out-String)
+
 Set-ExecutionPolicy -ExecutionPolicy Bypass -Scope LocalMachine
 </powershell>

scripts/gcp/setup-winrm.ps1

@@ -32,3 +32,8 @@ if (-not (Get-Command Enable-WinRM -errorAction SilentlyContinue))
 
 Write-Log "Invoking WinRM"
 Enable-WinRM
+
+Write-Log "Install OpenSSH.Server"
+Write-Log (Get-WindowsCapability -Online -Name "OpenSSH.Server*" | Format-List | Out-String)
+Add-WindowsCapability -Online -Name (Get-WindowsCapability -Online -Name "OpenSSH.Server*" | ForEach-Object Name)
+Write-Log (Get-WindowsCapability -Online -Name "OpenSSH.Server*" | Format-List | Out-String)

spec/packer/config/gcp_spec.rb

@@ -22,28 +22,30 @@
         vm_type: 'some-vm-type',
     ).builders }
 
-    let (:baseline_builders) { {
-            'type' => 'googlecompute',
-            'credentials_json' => 'some-account-json',
-            'project_id' => 'some-project-id',
-            'tags' => ['winrm'],
-            'source_image' => 'some-source-image',
-            'image_family' => 'some-image-family',
-            'zone' => 'us-west1-c',
-            'disk_size' => 32,
-            'machine_type' => 'some-vm-type',
-            'omit_external_ip' => false,
-            'communicator' => 'winrm',
-            'winrm_username' => 'winrmuser',
-            'winrm_use_ssl' => false,
-            'winrm_timeout' => '1h',
-            'state_timeout' => '10m',
-            'metadata' => {
-                'sysprep-specialize-script-url' => 'https://raw.githubusercontent.com/cloudfoundry/bosh-windows-stemcell-builder/master/scripts/gcp/setup-winrm.ps1',
-                'name' => "some-vm-prefix-#{Time.now.to_i}"
-            }
+    let(:baseline_builders) do
+      {
+        'type' => 'googlecompute',
+        'credentials_json' => 'some-account-json',
+        'project_id' => 'some-project-id',
+        'tags' => ['winrm'],
+        'source_image' => 'some-source-image',
+        'image_family' => 'some-image-family',
+        'zone' => 'us-west1-c',
+        'disk_size' => 32,
+        'machine_type' => 'some-vm-type',
+        'omit_external_ip' => false,
+        'communicator' => 'winrm',
+        'winrm_username' => 'winrmuser',
+        'winrm_use_ssl' => false,
+        'winrm_timeout' => '1h',
+        'state_timeout' => '10m',
+        'metadata' => {
+          'sysprep-specialize-script-ps1' => anything,
+          'name' => "some-vm-prefix-#{Time.now.to_i}"
+        }
 
-    } }
+      }
+    end
 
     context 'all os versions' do
       let(:os) { '' }