Add OS and version to packer output

This adds the OS and version to packer-created files in the storage
account. This should make it easier to clean up older stemcells in the
future, beyond just checking creation date.

Author: ystros

lib/packer/config/azure.rb

@@ -32,8 +32,8 @@ def builders
                 'resource_group_name' => @resource_group_name,
                 'temp_resource_group_name' => "#{@vm_prefix}-#{Time.now.to_i}",
                 'storage_account' => @storage_account,
-                'capture_container_name' => 'packer-stemcells',
-                'capture_name_prefix' => 'bosh-stemcell',
+                'capture_container_name' => @os,
+                'capture_name_prefix' => "bosh-stemcell-#{@os}-#{@version}",
                 'image_publisher' => 'MicrosoftWindowsServer',
                 'image_offer' => ENV['BASE_IMAGE_OFFER'],
                 'image_sku' => ENV['BASE_IMAGE'],

spec/packer/config/azure_spec.rb

@@ -23,8 +23,8 @@
         location: 'some-location',
         vm_size: 'some-vm-size',
         output_directory: '',
-        os: os,
-        version: '',
+        os: 'test-os',
+        version: '2019.9999',
         vm_prefix: 'some-vm-prefix',
         mount_ephemeral_disk: false,
     ).builders }
@@ -39,8 +39,8 @@
         'resource_group_name' => 'some-resource-group-name',
         'temp_resource_group_name' => "some-vm-prefix-#{Time.now.to_i}",
         'storage_account' => 'some-storage-account',
-        'capture_container_name' => 'packer-stemcells',
-        'capture_name_prefix' => 'bosh-stemcell',
+        'capture_container_name' => 'test-os',
+        'capture_name_prefix' => 'bosh-stemcell-test-os-2019.9999',
         'image_publisher' => 'MicrosoftWindowsServer',
         'image_offer' => 'some-base-image-offer',
         'image_sku' => 'some-base-image',
@@ -55,8 +55,6 @@
     } }
 
     context 'all os versions' do
-      let(:os) { '' }
-
       it 'returns the expected builders' do
         expect(builders[0]).to include(expected_baseline)
       end