CI: remove unused conditional from acceptance_test

Author: aramprice

acceptance_test/README.md

@@ -24,7 +24,6 @@ You can create a `config.json` file, eg:
   "vm_extensions": "<comma separated string of options, e.g. 50GB_ephemeral_disk>",
   "network": "<network from bosh cloud config>",
   "skip_cleanup": "<skip cleanup - if this is false all unused stemcells are deleted>"
-  "skip_ms_update_test": "<skip check-updates errand - if true, it will not test that all Windows updates are installed>",
   "ssh_disabled_by_default": "check ssh daemon default startup type - if true then it checks that the startup type is DISABLED. If false or missing, checks startup type is AUTOMATIC",
   "security_compliance_applied": "check that Microsoft Baseline policies have been applied"
 }

acceptance_test/main_test.go

@@ -147,12 +147,8 @@ var _ = Describe("BOSH Windows", func() {
 	})
 
 	It("is fully updated", func() { // 860s
-		if testConfig.SkipMSUpdateTest {
-			Skip("Skipping check-updates test - SkipMSUpdateTest set to true")
-		} else {
-			err := boshCommand.RunErrand("check-updates", deploymentName)
-			Expect(err).NotTo(HaveOccurred())
-		}
+		err := boshCommand.RunErrand("check-updates", deploymentName)
+		Expect(err).NotTo(HaveOccurred())
 	})
 
 	It("has all certificate authority certs that are present on the Windows Update Server", func() {
@@ -227,7 +223,6 @@ type TestConfig struct {
 	DefaultPassword           string `json:"default_password"`
 	SkipCleanup               bool   `json:"skip_cleanup"`
 	MountEphemeralDisk        bool   `json:"mount_ephemeral_disk"`
-	SkipMSUpdateTest          bool   `json:"skip_ms_update_test"`
 	SSHDisabledByDefault      bool   `json:"ssh_disabled_by_default"`
 	SecurityComplianceApplied bool   `json:"security_compliance_applied"`
 }

ci/tasks/run-bwats/run

@@ -19,10 +19,6 @@ if [ "$SSH_DISABLED_BY_DEFAULT" != "true" ] ; then
   SSH_DISABLED_BY_DEFAULT="false"
 fi
 
-if [ "$SKIP_MS_UPDATE_TEST" != "true" ] ; then
-  SKIP_MS_UPDATE_TEST="false"
-fi
-
 if [ "$SECURITY_COMPLIANCE_APPLIED" != "true" ] ; then
   SECURITY_COMPLIANCE_APPLIED="false"
 fi
@@ -48,7 +44,6 @@ pushd stemcell-builder/acceptance_test
     "ssh_disabled_by_default": $SSH_DISABLED_BY_DEFAULT,
     "default_username" : "$DEFAULT_USERNAME",
     "default_password" : "$DEFAULT_PASSWORD",
-    "skip_ms_update_test": $SKIP_MS_UPDATE_TEST,
     "security_compliance_applied": $SECURITY_COMPLIANCE_APPLIED
   }
 END_OF_CONFIG

ci/tasks/run-bwats/task.yml

@@ -20,7 +20,6 @@ params:
   GINKGO_SKIP:
   IAAS:
   NETWORK: default
-  SKIP_MS_UPDATE_TEST: false
   SSH_DISABLED_BY_DEFAULT: false
   SSH_TUNNEL_IP:
   SSH_TUNNEL_PRIVATE_KEY: