stembuild: specs use timestamp suffix

Replaces the use of a random number or UUID fragment to make it easier
to identify stale resources.

Use `-` to separate OS verson from IP address suffix in construct specs

Author: aramprice

ci/tasks/setup-integration-test-vm/run.sh

@@ -9,7 +9,7 @@ export OUTPUT_DIR=${ROOT_DIR}/output
 VM_IP=$(cat nimbus-ips/name)
 CLONE_NAME_PREFIX="construct-${JOB_OS_NAME}-integration-ci-${OS_LINE}"
 CLONE_NAME_SUFFIX=$(echo "${VM_IP}" | cut -d . -f 4)
-CLONE_NAME=${CLONE_NAME_PREFIX}${CLONE_NAME_SUFFIX}
+CLONE_NAME=${CLONE_NAME_PREFIX}-${CLONE_NAME_SUFFIX}
 
 export VM_IP
 export CLONE_NAME_PREFIX

stembuild/iaas_cli/iaas_clients/iaas_clients_suite_test.go

@@ -7,7 +7,6 @@ import (
 	"testing"
 	"time"
 
-	"github.com/google/uuid"
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 	"github.com/vmware/govmomi/object"
@@ -60,7 +59,7 @@ var _ = BeforeSuite(func() {
 	vmToClone, err := vCenterManager.FindVM(CTX, testVmPath)
 	Expect(err).ToNot(HaveOccurred())
 
-	TestVmPath = testVmPath + fmt.Sprintf("%s", uuid.New())[0:8] //nolint:staticcheck
+	TestVmPath = fmt.Sprintf("%s-%s", testVmPath, time.Now().Format("2006-01-02T15h04s05"))
 
 	err = vCenterManager.CloneVM(CTX, vmToClone, TestVmPath)
 	Expect(err).ToNot(HaveOccurred())

stembuild/integration/package/package_test.go

@@ -6,7 +6,6 @@ import (
 	"crypto/sha1"
 	"fmt"
 	"io"
-	"math/rand"
 	"os"
 	"path/filepath"
 	"strings"
@@ -33,7 +32,7 @@ var _ = Describe("Package", func() {
 
 	BeforeEach(func() {
 		vcenterFolder := helpers.EnvMustExist(vcenterFolderVariable)
-		packageTestVMName := fmt.Sprintf("stembuild-package-test-%d", rand.Int())
+		packageTestVMName := fmt.Sprintf("stembuild-package-test-%s", time.Now().Format("2006-01-02T15h04s05"))
 
 		baseVMWithPath := strings.Join([]string{vcenterFolder, baseVMName}, "/")
 		vmPath = strings.Join([]string{vcenterFolder, packageTestVMName}, "/")