Update pester in automation helper test

Author: aramprice

ci/pipelines/stemcells-windows.yml

@@ -160,11 +160,6 @@ resources:
   type: git
   source:
     uri: https://github.com/cloudfoundry/windows-utilities-release.git
-- name: pester
-  type: git
-  source:
-    uri: https://github.com/pester/Pester.git
-    tag_filter: 4.4.0
 - name: bosh-windows-acceptance-tests-src-out
   type: git
   source:
@@ -686,9 +681,17 @@ jobs:
           - get: bosh-windows-stemcell-builder-ci
           - get: stemcell-builder
             trigger: true
-    - task: test-units-bosh-psmodules
-      file: bosh-windows-stemcell-builder-ci/ci/tasks/test-units-bosh-psmodules/task.yml
-      tags: [windows-nimbus]
+    - in_parallel:
+      - task: test-units-bosh-psmodules
+        file: bosh-windows-stemcell-builder-ci/ci/tasks/test-units-bosh-psmodules/task.yml
+        tags: [windows-nimbus]
+        params:
+          MODULES_DIR: modules
+      - task: test-units-bosh-psmodules-stembuild
+        file: bosh-windows-stemcell-builder-ci/ci/tasks/test-units-bosh-psmodules/task.yml
+        tags: [windows-nimbus]
+        params:
+          MODULES_DIR: stembuild/modules
 - name: test-stemcell-builder
   serial: true
   plan:
@@ -822,7 +825,6 @@ jobs:
       steps:
       - get: bosh-windows-stemcell-builder-ci
       - get: bosh-windows-stemcell-builder-ci-image
-      - get: pester
       - get: open-ssh
         resource: openssh-release
       - get: stemcell-builder
@@ -932,7 +934,6 @@ jobs:
       steps:
       - get: bosh-windows-stemcell-builder-ci
       - get: bosh-windows-stemcell-builder-ci-image
-      - get: pester
       - get: open-ssh
         resource: openssh-release
       - get: stemcell-builder

ci/tasks/test-units-bosh-psmodules/run.ps1

@@ -3,11 +3,9 @@ function New-TemporaryDirectory {
   $name = (New-Guid).ToString("N")
   New-Item -ItemType Directory -Path (Join-Path $tmp $name)
 }
-
 $moduleDir = New-TemporaryDirectory
 $pesterModule = Find-Module -Name Pester -MaximumVersion "5.9999" -MinimumVersion "5.0"
 $pesterModule | Save-Module -Path $moduleDir
-
 Import-Module "$moduleDir\Pester\$($pesterModule.Version)\Pester.psm1"
 
 $status = (Get-Service -Name "wuauserv").Status
@@ -17,7 +15,7 @@ $startupType = Get-Service "wuauserv" | Select-Object -ExpandProperty StartType
 
 $result = 0
 
-$testModules =  Get-ChildItem "./bosh-psmodules-repo/modules/" -recurse | where {$_.name -match ".*.Tests.ps1"} | foreach {$_.DirectoryName}
+$testModules = Get-ChildItem "./stemcell-builder/$env:MODULES_DIR" -recurse | where {$_.name -match ".*.Tests.ps1"} | foreach {$_.DirectoryName}
 foreach ($module in $testModules) {
     Write-Host "Testing: $module"
     Push-Location "$module"
@@ -33,6 +31,5 @@ foreach ($module in $testModules) {
     Pop-Location
 }
 
-echo "Failed Tests: $result"
+echo "Failed Test Count: $result"
 exit $result
-

ci/tasks/test-units-bosh-psmodules/task.yml

@@ -5,6 +5,9 @@ inputs:
   - name: bosh-windows-stemcell-builder-ci
   - name: stemcell-builder
 
+params:
+  MODULES_DIR:
+
 run:
   path: powershell
   args:

ci/tasks/test-units-stemcell-automation/task.yml

@@ -3,19 +3,37 @@ platform: windows
 inputs:
   - name: bosh-windows-stemcell-builder-ci
   - name: stemcell-builder
-  - name: pester
+
+params:
+  STEMCELL_AUTOMATION_DIR: stemcell-builder/stembuild/stemcell-automation/
 
 run:
   path: powershell
   args:
     - "-Command"
-    - "& {
-            Import-Module ./bosh-windows-stemcell-builder-ci/ci/common-scripts/setup-windows-container.psm1;
-            Set-TmpDir;
-            Import-Module ./Pester/pester.psm1;
-            pushd stemcell-builder/stembuild/stemcell-automation;
-            $result=Invoke-Pester -PassThru;
-            popd;
-            Write-Host \"Failed Tests:\"$result.FailedCount;
-            exit $result.FailedCount
-          }"
+    - |
+      & {
+          function New-TemporaryDirectory {
+            $tmp = [System.IO.Path]::GetTempPath() # Not $env:TEMP, see https://stackoverflow.com/a/946017
+            $name = (New-Guid).ToString("N")
+            New-Item -ItemType Directory -Path (Join-Path $tmp $name)
+          }
+          $moduleDir = New-TemporaryDirectory
+          $pesterModule = Find-Module -Name Pester -MaximumVersion "5.9999" -MinimumVersion "5.0"
+          $pesterModule | Save-Module -Path $moduleDir
+          Import-Module "$moduleDir\Pester\$($pesterModule.Version)\Pester.psm1"
+
+          Import-Module ./bosh-windows-stemcell-builder-ci/ci/common-scripts/setup-windows-container.psm1
+
+          Set-TmpDir
+          pushd $env:STEMCELL_AUTOMATION_DIR
+          # NOTE: uncomment the lines below to see full stack trace
+          # $configuration = New-PesterConfiguration
+          # $configuration.Output.StackTraceVerbosity = "Full"
+          # $result=Invoke-Pester -Configuration $configuration
+          $result=Invoke-Pester -PassThru
+          popd;
+
+          Write-Host "Failed Test Count:"$result.FailedCount
+          exit $result.FailedCount
+        }

stembuild/modules/BOSH.CFCell/BOSH.CFCell.Tests.ps1

@@ -8,6 +8,8 @@ BeforeAll {
 
 Describe "Protect-CFCell" {
     BeforeEach {
+        Mock -ModuleName BOSH.CFCell Write-Log { }
+
         $oldWinRMStatus = (Get-Service winrm).Status
         $oldWinRMStartMode = ( Get-Service winrm ).StartType