modules: powershell / ruby lint fixes

Author: aramprice

modules/BOSH.Account/BOSH.Account.Tests.ps1

@@ -31,7 +31,7 @@ Describe "BOSH.Account" {
         }
 
         BeforeEach {
-            $userExists = !!(Get-LocalUser | Where { $_.Name -eq $user })
+            $userExists = !!(Get-LocalUser | Where-Object { $_.Name -eq $user })
             if ($userExists)
             {
                 Remove-LocalUser -Name $user

modules/BOSH.CFCell/BOSH.CFCell.Tests.ps1

@@ -43,7 +43,7 @@ Describe "BOSH.CFCell" {
 
             Protect-CFCell -IaaS "ignored"
 
-            Get-ItemProperty -Path "HKLM:\System\CurrentControlSet\Control\Terminal Server" | select -exp fDenyTSConnections | Should -Be 1
+            Get-ItemProperty -Path "HKLM:\System\CurrentControlSet\Control\Terminal Server" | Select-Object -exp fDenyTSConnections | Should -Be 1
             netstat /p tcp /a | findstr ":3389 " | Should -BeNullOrEmpty
             Get-NetFirewallRule -DisplayName "Remote Desktop*" | ForEach-Object { $_.enabled | Should -Be "False" }
             Get-Service "Termservice" | Select-Object -exp starttype | Should -Be "Disabled"

modules/BOSH.SSH/BOSH.SSH.Tests.ps1

@@ -52,9 +52,9 @@ BeforeAll {
 
         mkdir "$dir\OpenSSH-Win64"
         $installSpyBehavior = "echo installed > $installScriptSpyStatus"
-        echo $installSpyBehavior > "$dir\OpenSSH-Win64\install-sshd.ps1"
-        echo "fake sshd" > "$dir\OpenSSH-Win64\sshd.exe"
-        echo "fake config" > "$dir\OpenSSH-Win64\sshd_config_default"
+        Write-Output $installSpyBehavior > "$dir\OpenSSH-Win64\install-sshd.ps1"
+        Write-Output "fake sshd" > "$dir\OpenSSH-Win64\sshd.exe"
+        Write-Output "fake config" > "$dir\OpenSSH-Win64\sshd_config_default"
 
         Compress-Archive -Force -Path "$dir\OpenSSH-Win64" -DestinationPath $fakeZipPath
     }
@@ -79,7 +79,7 @@ Describe "BOSH.SSH" {
             CreateFakeOpenSSHZip -dir $TMP_DIR -installScriptSpyStatus $INSTALL_SCRIPT_SPY_STATUS -fakeZipPath $FAKE_ZIP
 
             mkdir -p "$TMP_DIR\Windows\Temp"
-            echo "fake LGPO" > "$TMP_DIR\Windows\LGPO.exe"
+            Write-Output "fake LGPO" > "$TMP_DIR\Windows\LGPO.exe"
 
             $ORIGINAL_WINDIR = $env:WINDIR
             $env:WINDIR = "$TMP_DIR\Windows"

modules/BOSH.Sysprep/print_conflicted_from_audit_csv.rb

@@ -17,11 +17,11 @@ def self.from_string(s)
     AuditFile.new(header, contents)
   end
 
-  def print()
+  def print
     ([header] + contents).join("\r\n")
   end
 
-  def uniq()
+  def uniq
     uniqed = contents.uniq do |x|
       values = x.split(',')
       keys = values[0..5].join('').downcase
@@ -32,7 +32,7 @@ def uniq()
     AuditFile.new(header, uniqed)
   end
 
-  def size()
+  def size
     contents.size
   end
 end

modules/BOSH.WindowsUpdates/BOSH.WindowsUpdates.psm1

@@ -101,7 +101,6 @@ function Install-WindowsUpdates
 
 function Invoke-RebootOrComplete
 {
-    $RegistryEntry = "InstallWindowsUpdates"
     switch ($script:RestartRequired)
     {
         0 {