Powershell: normalize powershell style

Author: aramprice

ci/tasks/test-units-bosh-psmodules/run.ps1

@@ -23,7 +23,7 @@ foreach ($module in $testModules) {
     # Do not set $ErrorActionPreference and let Pester handle it nativetly; setting it to Stop globally will
     # break the tests since they are written with the assumption non zero exit codes will not fail a test
     # See: https://github.com/pester/Pester/issues/1404#issuecomment-568659518 for details
-    $results=Invoke-Pester -PassThru
+    $results=Invoke-Pester -PassThru # append "-Output Diagnostic" for verbose output
     if ($results.FailedCount -gt 0) {
       $result += $results.FailedCount
     }

modules/BOSH.Account/BOSH.Account.Tests.ps1

@@ -25,14 +25,15 @@ Describe "BOSH.Account" {
 
     Context "when the username and password are valid" {
         BeforeAll {
-            $timestamp=(get-date -UFormat "%s" -Millisecond 0)
+            $timestamp = (get-date -UFormat "%s" -Millisecond 0)
             $user = "TestUser_$timestamp"
             $password = "Password123!"
         }
 
-         BeforeEach {
-            $userExists = !!(Get-LocalUser | Where {$_.Name -eq $user})
-            if($userExists) {
+        BeforeEach {
+            $userExists = !!(Get-LocalUser | Where { $_.Name -eq $user })
+            if ($userExists)
+            {
                 Remove-LocalUser -Name $user
             }
         }
@@ -41,10 +42,10 @@ Describe "BOSH.Account" {
             Add-Account -User $user -Password $password
             mkdir "C:\Users\$user" -ErrorAction Ignore
             $adsi = [ADSI]"WinNT://$env:COMPUTERNAME"
-            $existing = $adsi.Children | Where-Object {$_.SchemaClassName -eq 'user' -and $_.Name -eq $user }
+            $existing = $adsi.Children | Where-Object { $_.SchemaClassName -eq 'user' -and $_.Name -eq $user }
             $existing | Should -Not -Be $null
             Remove-Account -User $user
-            $existing = $adsi.Children | Where-Object {$_.SchemaClassName -eq 'user' -and $_.Name -eq $user }
+            $existing = $adsi.Children | Where-Object { $_.SchemaClassName -eq 'user' -and $_.Name -eq $user }
             $existing | Should -Be $null
         }
     }

modules/BOSH.Account/BOSH.Account.psd1

@@ -1,21 +1,21 @@
 @{
-RootModule = 'BOSH.Account'
-ModuleVersion = '0.1'
-GUID = 'ebdf7a79-39df-46ce-a046-42dd10de82ce'
-Author = 'BOSH'
-Copyright = '(c) 2017 BOSH'
-Description = 'Commands for creating a new Windows user'
-PowerShellVersion = '4.0'
-RequiredModules = @('BOSH.Utils')
-FunctionsToExport = @('Add-Account','Remove-Account')
-CmdletsToExport = @()
-VariablesToExport = '*'
-AliasesToExport = @()
-PrivateData = @{
-    PSData = @{
-        Tags = @('BOSH')
-        LicenseUri = 'https://github.com/cloudfoundry/bosh-windows-stemcell-builder/blob/master/LICENSE'
-        ProjectUri = 'https://github.com/cloudfoundry/bosh-windows-stemcell-builder'
+    RootModule = 'BOSH.Account'
+    ModuleVersion = '0.1'
+    GUID = 'ebdf7a79-39df-46ce-a046-42dd10de82ce'
+    Author = 'BOSH'
+    Copyright = '(c) 2017 BOSH'
+    Description = 'Commands for creating a new Windows user'
+    PowerShellVersion = '4.0'
+    RequiredModules = @('BOSH.Utils')
+    FunctionsToExport = @('Add-Account', 'Remove-Account')
+    CmdletsToExport = @()
+    VariablesToExport = '*'
+    AliasesToExport = @()
+    PrivateData = @{
+        PSData = @{
+            Tags = @('BOSH')
+            LicenseUri = 'https://github.com/cloudfoundry/bosh-windows-stemcell-builder/blob/master/LICENSE'
+            ProjectUri = 'https://github.com/cloudfoundry/bosh-windows-stemcell-builder'
+        }
     }
 }
-}

modules/BOSH.Account/BOSH.Account.psm1

@@ -4,11 +4,12 @@
 .Description
     This cmdlet adds a Windows user
 #>
-function Add-Account {
+function Add-Account
+{
     Param(
-            [string]$User = $(Throw "Provide a user name"),
-            [string]$Password = $(Throw "Provide a password")
-         )
+        [string]$User = $( Throw "Provide a user name" ),
+        [string]$Password = $( Throw "Provide a password" )
+    )
     Write-Log "Add-Account"
 
     Write-Log "Creating new local user $User."
@@ -19,9 +20,9 @@ function Add-Account {
     Write-Log "Adding local user $User to $Group."
     $adsi = [ADSI]"WinNT://$env:COMPUTERNAME"
     Write-Log $adsi
-    $AdminGroup = $adsi.Children | Where-Object {$_.SchemaClassName -eq 'group' -and $_.Name -eq $Group }
+    $AdminGroup = $adsi.Children | Where-Object { $_.SchemaClassName -eq 'group' -and $_.Name -eq $Group }
     Write-Log $AdminGroup
-    $UserObject = $adsi.Children | Where-Object {$_.SchemaClassName -eq 'user' -and $_.Name -eq $User }
+    $UserObject = $adsi.Children | Where-Object { $_.SchemaClassName -eq 'user' -and $_.Name -eq $User }
     Write-Log $UserObject
     $AdminGroup.Add($UserObject.Path)
     Write-Log "Completed adding $User to $Group"
@@ -33,10 +34,11 @@ Remove Windows user
 .Description
 This cmdlet removes a Windows user
 #>
-function Remove-Account {
+function Remove-Account
+{
     Param(
-            [string]$User = $(Throw "Provide a user name")
-         )
+        [string]$User = $( Throw "Provide a user name" )
+    )
     Write-Log "Remove-Account"
     Write-Log "Removing local user $User."
     $adsi = [ADSI]"WinNT://$env:COMPUTERNAME"

modules/BOSH.Agent/BOSH.Agent.psd1

@@ -1,21 +1,21 @@
 @{
-RootModule = 'BOSH.Agent'
-ModuleVersion = '0.1'
-GUID = 'f46b71ee-4312-4f80-34c7-665d64250ae8'
-Author = 'BOSH'
-Copyright = '(c) 2017 BOSH'
-Description = 'Install BOSH-Agent on a BOSH deployed vm'
-PowerShellVersion = '4.0'
-RequiredModules = @('BOSH.Utils')
-FunctionsToExport = @('Install-Agent','Enable-AgentService','Disable-AgentService')
-CmdletsToExport = @()
-VariablesToExport = '*'
-AliasesToExport = @()
-PrivateData = @{
-    PSData = @{
-        Tags = @('BOSH')
-        LicenseUri = 'https://github.com/cloudfoundry/bosh-windows-stemcell-builder/blob/master/LICENSE'
-        ProjectUri = 'https://github.com/cloudfoundry/bosh-windows-stemcell-builder'
+    RootModule = 'BOSH.Agent'
+    ModuleVersion = '0.1'
+    GUID = 'f46b71ee-4312-4f80-34c7-665d64250ae8'
+    Author = 'BOSH'
+    Copyright = '(c) 2017 BOSH'
+    Description = 'Install BOSH-Agent on a BOSH deployed vm'
+    PowerShellVersion = '4.0'
+    RequiredModules = @('BOSH.Utils')
+    FunctionsToExport = @('Install-Agent', 'Enable-AgentService', 'Disable-AgentService')
+    CmdletsToExport = @()
+    VariablesToExport = '*'
+    AliasesToExport = @()
+    PrivateData = @{
+        PSData = @{
+            Tags = @('BOSH')
+            LicenseUri = 'https://github.com/cloudfoundry/bosh-windows-stemcell-builder/blob/master/LICENSE'
+            ProjectUri = 'https://github.com/cloudfoundry/bosh-windows-stemcell-builder'
+        }
     }
 }
-}