CI: add debug flag to stembuild

- move artifacts to a single directory
- cleanup shellcheck issues

Author: aramprice

ci/tasks/run-construct-stembuild-linux/run.sh

@@ -1,25 +1,34 @@
 #!/usr/bin/env bash
-set -ex
+set -eu -o pipefail
+set -x
 
+ROOT_DIR="$( pwd )"
 SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )"
 
-source ${SCRIPT_DIR}/../../common-scripts/update_nimbus_urls_and_cert.sh
+source "${SCRIPT_DIR}/../../common-scripts/update_nimbus_urls_and_cert.sh"
 
-cat > ca.crt <<END_OF_CERT
+build_dir="${ROOT_DIR}/build-dir"
+mkdir -p "${build_dir}"
+
+ca_cert_file="${ROOT_DIR}/ca.crt"
+cat > "${ca_cert_file}" <<END_OF_CERT
 $VCENTER_CA_CERT
 END_OF_CERT
 
-pushd stembuild-untested-linux
-  mv stembuild* stembuild
-popd
-mv stembuild-untested-linux/stembuild .
+cp lgpo-binary/LGPO*.zip "${build_dir}/LGPO.zip"
 
-mv lgpo-binary/LGPO*.zip LGPO.zip
+cp stembuild-untested-linux/stembuild* "${build_dir}/stembuild"
+chmod 500 "${build_dir}/stembuild"
 
-chmod 500 stembuild
-./stembuild construct \
-  -vcenter-url ${VCENTER_BASE_URL} -vcenter-username ${VCENTER_USERNAME} -vcenter-password ${VCENTER_PASSWORD} \
-  -vcenter-ca-certs ca.crt \
-  -vm-inventory-path ${VCENTER_VM_FOLDER}/${STEMBUILD_BASE_VM_NAME} \
-  -vm-ip ${STEMBUILD_BASE_VM_IP} -vm-username ${STEMBUILD_BASE_VM_USERNAME} -vm-password ${STEMBUILD_BASE_VM_PASSWORD} \
-  -setup-arg FailOnInstallWUCerts
+pushd "${build_dir}"
+  ./stembuild -debug construct \
+    -vcenter-url "${VCENTER_BASE_URL}" \
+      -vcenter-username "${VCENTER_USERNAME}" \
+      -vcenter-password "${VCENTER_PASSWORD}" \
+    -vcenter-ca-certs "${ca_cert_file}" \
+    -vm-inventory-path "${VCENTER_VM_FOLDER}/${STEMBUILD_BASE_VM_NAME}" \
+    -vm-ip "${STEMBUILD_BASE_VM_IP}" \
+      -vm-username "${STEMBUILD_BASE_VM_USERNAME}" \
+      -vm-password "${STEMBUILD_BASE_VM_PASSWORD}" \
+    -setup-arg FailOnInstallWUCerts
+popd