stembuild: vmconstruct code cleanup

- rename constant for clarity
- use backtick to elimiate string escaping

Author: aramprice

stembuild/construct/vmconstruct.go

@@ -42,13 +42,15 @@ type VMConstruct struct {
 	SetupFlags            []string
 }
 
-const provisionDir = "C:\\provision\\"
+const powershellExePath = `C:\Windows\System32\WindowsPowerShell\V1.0\powershell.exe`
+
+const provisionDir = `C:\provision\`
 const stemcellAutomationName = "StemcellAutomation.zip"
 const stemcellAutomationDest = provisionDir + stemcellAutomationName
 const lgpoDest = provisionDir + "LGPO.zip"
 const stemcellAutomationSetupScript = provisionDir + "Setup.ps1"
 const stemcellAutomationPostRebootScript = provisionDir + "PostReboot.ps1"
-const powershell = "C:\\Windows\\System32\\WindowsPowerShell\\V1.0\\powershell.exe"
+
 const boshPsModules = "bosh-psmodules.zip"
 const winRMPsScript = "BOSH.WinRM.psm1"
 

stembuild/construct/winrm.go

@@ -35,7 +35,7 @@ func (w *WinRMManager) Enable() error {
 
 	base64WinRM := EncodePowershellCommand(rawWinRMwtCmd)
 
-	pid, err := w.GuestManager.StartProgramInGuest(context.Background(), powershell, fmt.Sprintf("-EncodedCommand %s", base64WinRM))
+	pid, err := w.GuestManager.StartProgramInGuest(context.Background(), powershellExePath, fmt.Sprintf("-EncodedCommand %s", base64WinRM))
 	if err != nil {
 		return fmt.Errorf(failureString, err)
 	}