Spec: replace duplicate constant w/ assertion

Author: aramprice

spec/integration/build/aws_spec.rb

@@ -88,7 +88,7 @@
 
       stemcell_manifest = YAML.load(read_from_tgz(stemcell, 'stemcell.MF'))
       expect(stemcell_manifest['version']).to eq('1200.3.1-build.2')
-      expect(stemcell_manifest['sha1']).to eq(EMPTY_FILE_SHA)
+      expect(stemcell_manifest['sha1']).to eq(Stemcell::Manifest::EMPTY_FILE_SHA)
       expect(stemcell_manifest['operating_system']).to eq(@os_version)
       expect(stemcell_manifest['api_version']).to eq(3)
       expect(stemcell_manifest['stemcell_formats']).to eq(['aws-light'])
@@ -263,7 +263,7 @@
       stemcell_manifest = YAML.load(read_from_tgz(stemcell, 'stemcell.MF'))
       expect(stemcell_manifest['version']).to eq('1200.3')
       expect(stemcell_manifest['api_version']).to eq(2)
-      expect(stemcell_manifest['sha1']).to eq(EMPTY_FILE_SHA)
+      expect(stemcell_manifest['sha1']).to eq(Stemcell::Manifest::EMPTY_FILE_SHA)
       expect(stemcell_manifest['operating_system']).to eq(@os_version)
       expect(stemcell_manifest['cloud_properties']['infrastructure']).to eq('aws')
       expect(stemcell_manifest['cloud_properties']['encrypted']).to eq(false)

spec/integration/build/azure_spec.rb

@@ -83,7 +83,7 @@
 
       expect(stemcell_manifest['api_version']).to eq(3)
 
-      expect(stemcell_manifest['sha1']).to eq(EMPTY_FILE_SHA)
+      expect(stemcell_manifest['sha1']).to eq(Stemcell::Manifest::EMPTY_FILE_SHA)
 
       expect(stemcell_manifest['operating_system']).to eq(os_version)
 

spec/integration/build/gcp_spec.rb

@@ -64,7 +64,7 @@
       stemcell_manifest = YAML.load(read_from_tgz(stemcell, 'stemcell.MF'))
       expect(stemcell_manifest['version']).to eq('1200.3.1-build.2')
       expect(stemcell_manifest['api_version']).to eq(3)
-      expect(stemcell_manifest['sha1']).to eq(EMPTY_FILE_SHA)
+      expect(stemcell_manifest['sha1']).to eq(Stemcell::Manifest::EMPTY_FILE_SHA)
       expect(stemcell_manifest['operating_system']).to eq(os_version)
       expect(stemcell_manifest['stemcell_formats']).to eq(['google-light'])
       expect(stemcell_manifest['cloud_properties']['infrastructure']).to eq('google')

spec/spec_helper.rb

@@ -1,10 +1,9 @@
 require 'simplecov'
 SimpleCov.start
-EMPTY_FILE_SHA = 'da39a3ee5e6b4b0d3255bfef95601890afd80709'
+
 require 'zip'
 require 'timecop'
 
-# Mock web requests
 require 'webmock/rspec'
 WebMock.disable_net_connect!(allow_localhost: true)
 
@@ -17,19 +16,9 @@
     mocks.verify_partial_doubles = true
   end
 
-  config.shared_context_metadata_behavior = :apply_to_host_groups
-
-  config.filter_run_when_matching :focus
-
-  config.example_status_persistence_file_path = "spec/examples.txt"
-
   if config.files_to_run.one?
     config.default_formatter = 'doc'
   end
-
-  config.order = :random
-
-  Kernel.srand config.seed
 end
 
 def tgz_extract(file_path, out_dir)

spec/stemcell/manifest_spec.rb

@@ -1,6 +1,14 @@
 require 'stemcell/manifest'
 
 describe Stemcell::Manifest do
+  describe 'EMPTY_FILE_SHA' do
+    let(:expected_empty_sha_value) { 'da39a3ee5e6b4b0d3255bfef95601890afd80709' }
+
+    it 'has the expected value' do
+      expect(Stemcell::Manifest::EMPTY_FILE_SHA).to eq(expected_empty_sha_value)
+    end
+  end
+
   describe 'Base' do
     describe 'dump' do
       it 'returns a valid stemcell manifest yaml string' do