Copy Pester updates to stembuild/modules/

Author: aramprice

modules/BOSH.Agent/BOSH.Agent.Tests.ps1

@@ -12,7 +12,6 @@ BeforeAll {
     }
 }
 
-
 Describe "Copy-Agent" {
     BeforeEach {
         $installDir=(New-TempDir)

modules/BOSH.CFCell/BOSH.CFCell.Tests.ps1

@@ -62,7 +62,6 @@ Describe "Protect-CFCell" {
 
 Describe "Install-CFFeatures" {
     It "restarts computer on Microsoft server 2016 and later" {
-
         Mock -ModuleName BOSH.CFCell Install-CFFeatures2012 { }
         Mock -ModuleName BOSH.CFCell Install-CFFeatures2016 { }
         Mock -ModuleName BOSH.CFCell Write-Error { }
@@ -83,7 +82,6 @@ Describe "Install-CFFeatures2016" {
         Mock Uninstall-WindowsFeature { }
         Mock -ModuleName BOSH.CFCell Uninstall-WindowsFeature { }
         Mock -ModuleName BOSH.CFCell Set-Service { }
-        # Mock Set-Service { }
         Mock -ModuleName BOSH.CFCell Restart-Computer { }
         Mock -ModuleName BOSH.CFCell Get-OSVersionString { "10.0.1803" }
     }

modules/BOSH.CFCell/BOSH.CFCell.psm1

@@ -1,8 +1,4 @@
-# function Get-OSVersionStringg {
-#   return [System.Environment]::OSVersion.Version.ToString()
-# }
-
-<#
+<#
 .Synopsis
     Install CloudFoundry Cell components for either 2012R2 or 2016
 .Description

modules/BOSH.Registry/BOSH.Registry.Tests.ps1

@@ -7,7 +7,7 @@ Describe "BOSH.Registry" {
         $newItemReturn = [pscustomobject]@{"NewPath" = "HKCU:/Path/created";}
         Mock -ModuleName BOSH.Registry New-Item { $newItemReturn }
         # reset for our -parameterfilter mock
-#        Mock -ModuleName BOSH.Registry New-Item { $newItemReturn } -ParameterFilter { $PSBoundParameters['ErrorAction'] -eq "Stop" }
+        #Mock -ModuleName BOSH.Registry New-Item { $newItemReturn } -ParameterFilter { $PSBoundParameters['ErrorAction'] -eq "Stop" }
     }
 
     It "Set-InternetExplorerRegistries applies internet explorer settings when valid policy files are generated" {

modules/BOSH.SSH/BOSH.SSH.Tests.ps1

@@ -1,8 +1,7 @@
 BeforeAll {
     Import-Module ./BOSH.SSH.psm1
 
-    function Get-FileEncoding
-    {
+    function Get-FileEncoding {
         [CmdletBinding()]
         param (
             [Alias("PSPath")]

stembuild/modules/BOSH.Account/BOSH.Account.Tests.ps1

@@ -1,27 +1,30 @@
-Remove-Module -Name BOSH.Account -ErrorAction Ignore
-Import-Module ./BOSH.Account.psm1
+BeforeAll {
+    Remove-Module -Name BOSH.Account -ErrorAction Ignore
+    Import-Module ./BOSH.Account.psm1
 
-Remove-Module -Name BOSH.Utils -ErrorAction Ignore
-Import-Module ../BOSH.Utils/BOSH.Utils.psm1
+    Remove-Module -Name BOSH.Utils -ErrorAction Ignore
+    Import-Module ../BOSH.Utils/BOSH.Utils.psm1
+}
 
 Describe "Account" {
-
     Context "when username is not provided" {
         It "throws" {
-            { Add-Account } | Should Throw "Provide a user name"
+            { Add-Account } | Should -Throw "Provide a user name"
         }
     }
 
     Context "when password is not provided" {
         It "throws" {
-            { Add-Account -User hello } | Should Throw "Provide a password"
+            { Add-Account -User hello } | Should -Throw "Provide a password"
         }
     }
 
     Context "when the username and password are valid" {
-        $timestamp=(get-date -UFormat "%s" -Millisecond 0)
-        $user = "TestUser_$timestamp"
-        $password = "Password123!"
+        BeforeAll {
+            $timestamp=(get-date -UFormat "%s" -Millisecond 0)
+            $user = "TestUser_$timestamp"
+            $password = "Password123!"
+        }
 
          BeforeEach {
             $userExists = !!(Get-LocalUser | Where {$_.Name -eq $user})
@@ -34,14 +37,11 @@ Describe "Account" {
             Add-Account -User $user -Password $password
             mkdir "C:\Users\$user" -ErrorAction Ignore
             $adsi = [ADSI]"WinNT://$env:COMPUTERNAME"
-            $existing = $adsi.Children | where {$_.SchemaClassName -eq 'user' -and $_.Name -eq $user }
-            $existing | Should Not Be $null
+            $existing = $adsi.Children | Where-Object {$_.SchemaClassName -eq 'user' -and $_.Name -eq $user }
+            $existing | Should -Not -Be $null
             Remove-Account -User $user
-            $existing = $adsi.Children | where {$_.SchemaClassName -eq 'user' -and $_.Name -eq $user }
-            $existing | Should Be $null
+            $existing = $adsi.Children | Where-Object {$_.SchemaClassName -eq 'user' -and $_.Name -eq $user }
+            $existing | Should -Be $null
         }
     }
 }
-
-Remove-Module -Name BOSH.Account -ErrorAction Ignore
-Remove-Module -Name BOSH.Utils -ErrorAction Ignore