cf revisions no longer reports EXPERIMENTAL notice [v7] (#3060)

* `cf revisions` no longer reports EXPERIMENTAL notice

* Move `revision` and `revisions` commands into APPS section of help

* Remove negative assertions for revision commands' experimental status

* Restore "revision" command to experimental status

* `cf rollback` no longer reports EXPERIMENTAL status

* Remove superfluous newline

Author: Michael Chinigo

command/common/internal/help_all_display.go

@@ -17,6 +17,7 @@ var HelpCategoryList = []HelpCategory{
 			{"start", "stop", "restart", "stage-package", "restage", "restart-app-instance"},
 			{"run-task", "tasks", "terminate-task"},
 			{"packages", "create-package"},
+			{"revisions", "rollback"},
 			{"droplets", "set-droplet", "download-droplet"},
 			{"events", "logs"},
 			{"env", "set-env", "unset-env"},
@@ -167,7 +168,7 @@ var ExperimentalHelpCategoryList = []HelpCategory{
 	{
 		CategoryName: "EXPERIMENTAL COMMANDS:",
 		CommandList: [][]string{
-			{"revisions", "revision", "rollback"},
+			{"revision"},
 		},
 	},
 }

command/v7/revisions_command.go

@@ -5,7 +5,6 @@ import (
 	"strconv"
 
 	"code.cloudfoundry.org/cli/actor/v7action"
-	"code.cloudfoundry.org/cli/command"
 	"code.cloudfoundry.org/cli/command/flag"
 	"code.cloudfoundry.org/cli/resources"
 	"code.cloudfoundry.org/cli/util/ui"
@@ -26,9 +25,6 @@ type RevisionsCommand struct {
 }
 
 func (cmd RevisionsCommand) Execute(_ []string) error {
-	cmd.UI.DisplayWarning(command.ExperimentalWarning)
-	cmd.UI.DisplayNewline()
-
 	err := cmd.SharedActor.CheckTarget(true, true)
 	if err != nil {
 		return err

command/v7/revisions_command_test.go

@@ -59,10 +59,6 @@ var _ = Describe("revisions Command", func() {
 		executeErr = cmd.Execute(nil)
 	})
 
-	It("displays the experimental warning", func() {
-		Expect(testUI.Err).To(Say("This command is in EXPERIMENTAL stage and may change without notice"))
-	})
-
 	When("checking target fails", func() {
 		BeforeEach(func() {
 			fakeSharedActor.CheckTargetReturns(actionerror.NotLoggedInError{BinaryName: binaryName})

command/v7/rollback_command.go

@@ -35,9 +35,6 @@ func (cmd *RollbackCommand) Setup(config command.Config, ui command.UI) error {
 }
 
 func (cmd RollbackCommand) Execute(args []string) error {
-	cmd.UI.DisplayWarning(command.ExperimentalWarning)
-	cmd.UI.DisplayNewline()
-
 	targetRevision := int(cmd.Version.Value)
 	err := cmd.SharedActor.CheckTarget(true, true)
 	if err != nil {

command/v7/rollback_command_test.go

@@ -82,10 +82,6 @@ var _ = Describe("rollback Command", func() {
 		executeErr = cmd.Execute(nil)
 	})
 
-	It("displays the experimental warning", func() {
-		Expect(testUI.Err).To(Say("This command is in EXPERIMENTAL stage and may change without notice"))
-	})
-
 	When("checking target fails", func() {
 		BeforeEach(func() {
 			fakeSharedActor.CheckTargetReturns(actionerror.NoOrganizationTargetedError{BinaryName: binaryName})

integration/v7/isolated/revisions_command_test.go

@@ -33,7 +33,7 @@ var _ = Describe("revisions command", func() {
 			It("appears in cf help -a", func() {
 				session := helpers.CF("help", "-a")
 				Eventually(session).Should(Exit(0))
-				Expect(session).To(HaveCommandInCategoryWithDescription("revisions", "EXPERIMENTAL COMMANDS", "List revisions of an app"))
+				Expect(session).To(HaveCommandInCategoryWithDescription("revisions", "APPS", "List revisions of an app"))
 			})
 
 			It("Displays command usage to output", func() {

integration/v7/isolated/rollback_command_test.go

@@ -21,7 +21,7 @@ var _ = Describe("rollback command", func() {
 			It("appears in cf help -a", func() {
 				session := helpers.CF("help", "-a")
 				Eventually(session).Should(Exit(0))
-				Expect(session).To(HaveCommandInCategoryWithDescription("rollback", "EXPERIMENTAL COMMANDS", "Rollback to the specified revision of an app"))
+				Expect(session).To(HaveCommandInCategoryWithDescription("rollback", "APPS", "Rollback to the specified revision of an app"))
 			})
 
 			It("Displays rollback command usage to output", func() {