Ensure response body is always closed in CloudControllerConnection (#2423)

chitoku-k · web-flow · commit 431f4e0b581a · 2024-01-18T10:03:27.000-08:00
diff --git a/api/cloudcontroller/cloud_controller_connection.go b/api/cloudcontroller/cloud_controller_connection.go
@@ -55,6 +55,7 @@ func (connection *CloudControllerConnection) Make(request *Request, passedRespon
 	if err != nil {
 		return connection.processRequestErrors(request.Request, err)
 	}
+	defer response.Body.Close()
 
 	return connection.populateResponse(response, passedResponse)
 }
@@ -64,7 +65,6 @@ func (*CloudControllerConnection) handleStatusCodes(response *http.Response, pas
 		passedResponse.RawResponse = []byte("{}")
 	} else {
 		rawBytes, err := ioutil.ReadAll(response.Body)
-		defer response.Body.Close()
 		if err != nil {
 			return err
 		}

Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,7 @@ func (connection CloudControllerConnection) Make(request Request, passedRespon`
`55`	`55`	`if err != nil {`
`56`	`56`	`return connection.processRequestErrors(request.Request, err)`
`57`	`57`	`}`
	`58`	`+ defer response.Body.Close()`
`58`	`59`
`59`	`60`	`return connection.populateResponse(response, passedResponse)`
`60`	`61`	`}`
`@@ -64,7 +65,6 @@ func (CloudControllerConnection) handleStatusCodes(response http.Response, pas`
`64`	`65`	`passedResponse.RawResponse = []byte("{}")`
`65`	`66`	`} else {`
`66`	`67`	`rawBytes, err := ioutil.ReadAll(response.Body)`
`67`		`- defer response.Body.Close()`
`68`	`68`	`if err != nil {`
`69`	`69`	`return err`
`70`	`70`	`}`