Skip to content

Commit 77b9311

Browse files
joaopapereirajoaopapereira
authored
[main] Fix linter issues (#3277)
1 parent 6bed63e commit 77b9311

File tree

43 files changed

+67
-69
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+67
-69
lines changed

‎.github/workflows/golangci-lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
- name: golangci-lint
3838
uses: golangci/golangci-lint-action@v6
3939
with:
40-
version: v1.58
40+
version: v1.61
4141
args: -v --exclude-dirs cf --exclude-dirs fixtures --exclude-dirs plugin --exclude-dirs command/plugin
4242
format:
4343
name: Run go fmt

‎.github/workflows/tests-integration.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,17 +101,17 @@ jobs:
101101
steps:
102102
- name: Checkout
103103
uses: actions/checkout@v4
104-
if: ${{ inputs.run_unit_tests == 'true' }}
104+
if: ${{ inputs.run_unit_tests || inputs.run_unit_tests == '' }}
105105
with:
106106
ref: ${{needs.get-sha.outputs.gitRef}}
107107
- name: Set Up Go
108108
uses: actions/setup-go@v5
109-
if: ${{ inputs.run_unit_tests == 'true' }}
109+
if: ${{ inputs.run_unit_tests || inputs.run_unit_tests == '' }}
110110
with:
111111
go-version-file: go.mod
112112
check-latest: true
113113
- name: Run Units
114-
if: ${{ inputs.run_unit_tests == 'true' }}
114+
if: ${{ inputs.run_unit_tests || inputs.run_unit_tests == '' }}
115115
run: make units
116116

117117
claim-env:
@@ -298,7 +298,7 @@ jobs:
298298
gitRef: ${{needs.get-sha.outputs.gitRef}}
299299
lease-id: ${{ needs.claim-env.outputs.leaseid }}
300300
lease-namespace: ${{ inputs.lease_namespace || vars.SHEPHERD_LEASE_NAMESPACE || 'tas-devex' }}
301-
nodes: ${{ inputs.nodes }}
301+
nodes: ${{ inputs.nodes || '16'}}
302302
secrets: inherit
303303

304304
run-integration-tests-cf-env-with-client-creds:
@@ -316,6 +316,7 @@ jobs:
316316
gitRef: ${{needs.get-sha.outputs.gitRef}}
317317
lease-id: ${{ needs.claim-env.outputs.leaseid }}
318318
lease-namespace: ${{ inputs.lease_namespace || vars.SHEPHERD_LEASE_NAMESPACE || 'tas-devex' }}
319+
nodes: ${{ inputs.nodes || '16'}}
319320
secrets: inherit
320321

321322
run-cats-cf-env:

‎.gitignore

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ tmp/
5757
fixtures/.cf
5858

5959
#Compiled Plugins
60-
fixtures/plugins/test_1
61-
fixtures/plugins/test_2
62-
fixtures/plugins/empty_plugin
60+
fixtures/plugins/test_1/test_1
61+
fixtures/plugins/test_2/test_2
62+
fixtures/plugins/empty_plugin/empty_plugin
6363
fixtures/config/plugin-config/.cf/plugins/test_1
6464
fixtures/config/plugin-config/.cf/plugins/test_2
6565
fixtures/config/plugin-config/.cf/plugins/empty_plugin

‎Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,13 +202,13 @@ units-plugin: install-test-deps
202202

203203
ifeq ($(OS),Windows_NT)
204204
units-non-plugin: install-test-deps
205-
@rm -f $(wildcard fixtures/plugins/*.exe)
205+
@rm -f $(wildcard fixtures/plugins/*/*.exe)
206206
@ginkgo version
207207
CF_HOME=$(CURDIR)/fixtures CF_USERNAME="" CF_PASSWORD="" $(ginkgo_units) \
208208
-skip-package integration,plugin,cf\actors\plugin,cf\commands\plugin,cf\actors\plugin,util\randomword
209209
else
210210
units-non-plugin: install-test-deps
211-
@rm -f $(wildcard fixtures/plugins/*.exe)
211+
@rm -f $(wildcard fixtures/plugins/*/*.exe)
212212
@ginkgo version
213213
CF_HOME=$(CURDIR)/fixtures CF_USERNAME="" CF_PASSWORD="" $(ginkgo_units) \
214214
-skip-package integration,plugin,cf/actors/plugin,cf/commands/plugin,cf/actors/plugin,util/randomword

‎cf/commands/plugin/install_plugin_test.go

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package plugin_test
22

33
import (
44
"fmt"
5-
"io/ioutil"
65
"net/http"
76
"net/http/httptest"
87
"os"
@@ -80,23 +79,23 @@ var _ = Describe("Install", func() {
8079
if err != nil {
8180
panic(err)
8281
}
83-
test_1 = filepath.Join(dir, "..", "..", "..", "fixtures", "plugins", "test_1.exe")
84-
test_2 = filepath.Join(dir, "..", "..", "..", "fixtures", "plugins", "test_2.exe")
82+
test_1 = filepath.Join(dir, "..", "..", "..", "fixtures", "plugins", "test_1", "test_1.exe")
83+
test_2 = filepath.Join(dir, "..", "..", "..", "fixtures", "plugins", "test_2", "test_2.exe")
8584
test_curDir = filepath.Join("test_1.exe")
86-
test_with_help = filepath.Join(dir, "..", "..", "..", "fixtures", "plugins", "test_with_help.exe")
87-
test_with_orgs = filepath.Join(dir, "..", "..", "..", "fixtures", "plugins", "test_with_orgs.exe")
88-
test_with_orgs_short_name = filepath.Join(dir, "..", "..", "..", "fixtures", "plugins", "test_with_orgs_short_name.exe")
89-
aliasConflicts = filepath.Join(dir, "..", "..", "..", "fixtures", "plugins", "alias_conflicts.exe")
85+
test_with_help = filepath.Join(dir, "..", "..", "..", "fixtures", "plugins", "test_with_help", "test_with_help.exe")
86+
test_with_orgs = filepath.Join(dir, "..", "..", "..", "fixtures", "plugins", "test_with_orgs", "test_with_orgs.exe")
87+
test_with_orgs_short_name = filepath.Join(dir, "..", "..", "..", "fixtures", "plugins", "test_with_orgs_short_name", "test_with_orgs_short_name.exe")
88+
aliasConflicts = filepath.Join(dir, "..", "..", "..", "fixtures", "plugins", "alias_conflicts", "alias_conflicts.exe")
9089

91-
homeDir, err = ioutil.TempDir(os.TempDir(), "plugins")
90+
homeDir, err = os.MkdirTemp(os.TempDir(), "plugins")
9291
Expect(err).ToNot(HaveOccurred())
9392

9493
pluginDir = filepath.Join(homeDir, ".cf", "plugins")
9594
pluginConfig.GetPluginPathReturns(pluginDir)
9695

9796
curDir, err = os.Getwd()
9897
Expect(err).ToNot(HaveOccurred())
99-
pluginFile, err = ioutil.TempFile("./", "test_plugin")
98+
pluginFile, err = os.CreateTemp("./", "test_plugin")
10099
Expect(err).ToNot(HaveOccurred())
101100

102101
if runtime.GOOS != "windows" {
@@ -541,7 +540,7 @@ var _ = Describe("Install", func() {
541540
runCommand(filepath.Join(curDir, pluginFile.Name()), "-f")
542541
Expect(ui.Outputs()).To(ContainSubstrings(
543542
[]string{"Installing plugin"},
544-
[]string{"The file", pluginFile.Name(), "already exists"},
543+
[]string{"The file", filepath.Clean(pluginFile.Name()), "already exists"},
545544
[]string{"FAILED"},
546545
))
547546
})
@@ -559,7 +558,7 @@ var _ = Describe("Install", func() {
559558
curDir, err := os.Getwd()
560559
Expect(err).ToNot(HaveOccurred())
561560

562-
err = os.Chdir("../../../fixtures/plugins")
561+
err = os.Chdir("../../../fixtures/plugins/test_1")
563562
Expect(err).ToNot(HaveOccurred())
564563

565564
runCommand(test_curDir, "-f")

‎cf/commands/plugin/plugin_suite_test.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@ func TestPlugin(t *testing.T) {
2121

2222
RegisterFailHandler(Fail)
2323

24-
pluginbuilder.BuildTestBinary(filepath.Join("..", "..", "..", "fixtures", "plugins"), "test_with_help")
25-
pluginbuilder.BuildTestBinary(filepath.Join("..", "..", "..", "fixtures", "plugins"), "test_with_orgs")
26-
pluginbuilder.BuildTestBinary(filepath.Join("..", "..", "..", "fixtures", "plugins"), "test_with_orgs_short_name")
27-
pluginbuilder.BuildTestBinary(filepath.Join("..", "..", "..", "fixtures", "plugins"), "test_with_push")
28-
pluginbuilder.BuildTestBinary(filepath.Join("..", "..", "..", "fixtures", "plugins"), "test_with_push_short_name")
29-
pluginbuilder.BuildTestBinary(filepath.Join("..", "..", "..", "fixtures", "plugins"), "test_1")
30-
pluginbuilder.BuildTestBinary(filepath.Join("..", "..", "..", "fixtures", "plugins"), "test_2")
31-
pluginbuilder.BuildTestBinary(filepath.Join("..", "..", "..", "fixtures", "plugins"), "empty_plugin")
32-
pluginbuilder.BuildTestBinary(filepath.Join("..", "..", "..", "fixtures", "plugins"), "alias_conflicts")
24+
pluginbuilder.BuildTestBinary(filepath.Join("..", "..", "..", "fixtures", "plugins", "test_with_help"), "test_with_help")
25+
pluginbuilder.BuildTestBinary(filepath.Join("..", "..", "..", "fixtures", "plugins", "test_with_orgs"), "test_with_orgs")
26+
pluginbuilder.BuildTestBinary(filepath.Join("..", "..", "..", "fixtures", "plugins", "test_with_orgs_short_name"), "test_with_orgs_short_name")
27+
pluginbuilder.BuildTestBinary(filepath.Join("..", "..", "..", "fixtures", "plugins", "test_with_push"), "test_with_push")
28+
pluginbuilder.BuildTestBinary(filepath.Join("..", "..", "..", "fixtures", "plugins", "test_with_push_short_name"), "test_with_push_short_name")
29+
pluginbuilder.BuildTestBinary(filepath.Join("..", "..", "..", "fixtures", "plugins", "test_1"), "test_1")
30+
pluginbuilder.BuildTestBinary(filepath.Join("..", "..", "..", "fixtures", "plugins", "test_2"), "test_2")
31+
pluginbuilder.BuildTestBinary(filepath.Join("..", "..", "..", "fixtures", "plugins", "empty_plugin"), "empty_plugin")
32+
pluginbuilder.BuildTestBinary(filepath.Join("..", "..", "..", "fixtures", "plugins", "alias_conflicts"), "alias_conflicts")
3333

3434
RunSpecs(t, "Plugin Suite")
3535
}

‎cf/commands/plugin/plugins_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ var _ = Describe("Plugins", func() {
4848
It("computes and prints the sha1 checksum of the binary", func() {
4949
config.PluginsReturns(map[string]pluginconfig.PluginMetadata{
5050
"Test1": {
51-
Location: "../../../fixtures/plugins/test_1.go",
51+
Location: "../../../fixtures/plugins/test_1/test_1.go",
5252
Version: plugin.VersionType{Major: 1, Minor: 2, Build: 3},
5353
Commands: []plugin.Command{
5454
{Name: "test_1_cmd1", HelpText: "help text for test_1_cmd1"},
@@ -157,7 +157,7 @@ var _ = Describe("Plugins", func() {
157157

158158
It("does not list the plugin when it provides no available commands", func() {
159159
config.PluginsReturns(map[string]pluginconfig.PluginMetadata{
160-
"EmptyPlugin": {Location: "../../../fixtures/plugins/empty_plugin.exe"},
160+
"EmptyPlugin": {Location: "../../../fixtures/plugins/empty_plugin/empty_plugin.exe"},
161161
})
162162

163163
runCommand()

‎cf/commands/plugin/uninstall_plugin_test.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package plugin_test
22

33
import (
4-
"io/ioutil"
54
"os"
65
"path/filepath"
76

@@ -41,7 +40,7 @@ var _ = Describe("Uninstall", func() {
4140
requirementsFactory = new(requirementsfakes.FakeFactory)
4241

4342
var err error
44-
fakePluginRepoDir, err = ioutil.TempDir("", "plugins")
43+
fakePluginRepoDir, err = os.MkdirTemp("", "plugins")
4544
Expect(err).ToNot(HaveOccurred())
4645

4746
fixtureDir := filepath.Join("..", "..", "..", "fixtures", "plugins")
@@ -50,8 +49,8 @@ var _ = Describe("Uninstall", func() {
5049
err = os.MkdirAll(pluginDir, 0700)
5150
Expect(err).NotTo(HaveOccurred())
5251

53-
fileutils.CopyPathToPath(filepath.Join(fixtureDir, "test_1.exe"), filepath.Join(pluginDir, "test_1.exe"))
54-
fileutils.CopyPathToPath(filepath.Join(fixtureDir, "test_2.exe"), filepath.Join(pluginDir, "test_2.exe"))
52+
fileutils.CopyPathToPath(filepath.Join(fixtureDir, "test_1", "test_1.exe"), filepath.Join(pluginDir, "test_1.exe"))
53+
fileutils.CopyPathToPath(filepath.Join(fixtureDir, "test_2", "test_2.exe"), filepath.Join(pluginDir, "test_2.exe"))
5554

5655
confighelpers.PluginRepoDir = func() string {
5756
return fakePluginRepoDir

‎cf/configuration/pluginconfig/plugin_config_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ var _ = Describe("PluginConfig", func() {
8383
}
8484

8585
metadata = PluginMetadata{
86-
Location: "../../../fixtures/plugins/test_1.exe",
86+
Location: "../../../fixtures/plugins/test_1/test_1.exe",
8787
Commands: commands1,
8888
}
8989
})
@@ -110,9 +110,9 @@ var _ = Describe("PluginConfig", func() {
110110
})
111111

112112
It("returns a list of plugin executables and their location", func() {
113-
Expect(plugins["Test1"].Location).To(Equal("../../../fixtures/plugins/test_1.exe"))
113+
Expect(plugins["Test1"].Location).To(Equal("../../../fixtures/plugins/test_1/test_1.exe"))
114114
Expect(plugins["Test1"].Commands).To(Equal(commands1))
115-
Expect(plugins["Test2"].Location).To(Equal("../../../fixtures/plugins/test_2.exe"))
115+
Expect(plugins["Test2"].Location).To(Equal("../../../fixtures/plugins/test_2/test_2.exe"))
116116
Expect(plugins["Test2"].Commands).To(Equal(commands2))
117117
})
118118
})

‎command/v7/push_command.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ type PushCommand struct {
107107
PathsToVarsFiles []flag.PathWithExistenceCheck `long:"vars-file" description:"Path to a variable substitution file for manifest; can specify multiple times"`
108108
Lifecycle constant.AppLifecycleType `long:"lifecycle" description:"App lifecycle type to stage and run the app" default:""`
109109
dockerPassword interface{} `environmentName:"CF_DOCKER_PASSWORD" environmentDescription:"Password used for private docker repository"`
110-
cnbCredentials interface{} `environmentName:"CNB_REGISTRY_CREDS" environmentDescription:"Credentials for pulling Cloud Native Buildpacks from private registries"`
111110
usage interface{} `usage:"CF_NAME push APP_NAME [-b BUILDPACK_NAME]\n [-c COMMAND] [-f MANIFEST_PATH | --no-manifest] [--lifecycle (buildpack | docker | cnb)] [--no-start] [--no-wait] [-i NUM_INSTANCES]\n [-k DISK] [-m MEMORY] [-l LOG_RATE_LIMIT] [-p PATH] [-s STACK] [-t HEALTH_TIMEOUT] [--task TASK]\n [-u (process | port | http)] [--no-route | --random-route]\n [--var KEY=VALUE] [--vars-file VARS_FILE_PATH]...\n \n CF_NAME push APP_NAME --docker-image [REGISTRY_HOST:PORT/]IMAGE[:TAG] [--docker-username USERNAME]\n [-c COMMAND] [-f MANIFEST_PATH | --no-manifest] [--no-start] [--no-wait] [-i NUM_INSTANCES]\n [-k DISK] [-m MEMORY] [-l LOG_RATE_LIMIT] [-p PATH] [-s STACK] [-t HEALTH_TIMEOUT] [--task TASK]\n [-u (process | port | http)] [--no-route | --random-route ]\n [--var KEY=VALUE] [--vars-file VARS_FILE_PATH]..."`
112111
envCFStagingTimeout interface{} `environmentName:"CF_STAGING_TIMEOUT" environmentDescription:"Max wait time for staging, in minutes" environmentDefault:"15"`
113112
envCFStartupTimeout interface{} `environmentName:"CF_STARTUP_TIMEOUT" environmentDescription:"Max wait time for app instance startup, in minutes" environmentDefault:"5"`

0 commit comments

Comments
 (0)