Fix improper Eventually usage in servicebrokerstub (#3647)

The ensureAppIsDeployed helper was calling appResponds() immediately and passing the result (a boolean) to Eventually. This prevented Gomega from polling the function, causing failures if the app wasn't ready instantly.

This change passes the function reference appResponds to Eventually so it can be polled correctly, and adds a 1-minute timeout to allow for slower environments.

Author: anujc25

integration/helpers/servicebrokerstub/app_deploy.go

@@ -37,7 +37,7 @@ func initialize() {
 func ensureAppIsDeployed() {
 	if !appResponds() {
 		ensureAppIsPushed()
-		Eventually(appResponds()).Should(BeTrue())
+		Eventually(appResponds, time.Minute).Should(BeTrue())
 	}
 }