Copy process user when creating a deployment

Author: tcdowney

app/actions/deployment_create.rb

@@ -113,6 +113,7 @@ def clone_existing_web_process(app, revision, process_instances)
           state: ProcessModel::STOPPED,
           instances: process_instances,
           command: command,
+          user: web_process.user,
           memory: web_process.memory,
           file_descriptors: web_process.file_descriptors,
           disk_quota: web_process.disk_quota,

spec/request/processes_spec.rb

@@ -116,6 +116,7 @@
             },
             'type' => 'web',
             'command' => '[PRIVATE DATA HIDDEN IN LISTS]',
+            'user' => 'vcap',
             'instances' => 2,
             'memory_in_mb' => 1024,
             'disk_in_mb' => 1024,
@@ -155,6 +156,7 @@
             },
             'type' => 'worker',
             'command' => '[PRIVATE DATA HIDDEN IN LISTS]',
+            'user' => 'vcap',
             'instances' => 1,
             'memory_in_mb' => 100,
             'disk_in_mb' => 200,
@@ -421,6 +423,7 @@
           'revision' => { 'data' => { 'guid' => revision.guid } }
         },
         'command' => 'rackup',
+        'user' => 'vcap',
         'instances' => 2,
         'memory_in_mb' => 1024,
         'disk_in_mb' => 1024,
@@ -704,6 +707,7 @@
         },
         'type' => 'web',
         'command' => 'new command',
+        'user' => 'vcap',
         'instances' => 2,
         'memory_in_mb' => 1024,
         'disk_in_mb' => 1024,
@@ -865,6 +869,7 @@
           'revision' => nil
         },
         'command' => 'rackup',
+        'user' => 'vcap',
         'instances' => 5,
         'memory_in_mb' => 10,
         'disk_in_mb' => 20,
@@ -1230,6 +1235,7 @@
             },
             'type' => 'web',
             'command' => '[PRIVATE DATA HIDDEN IN LISTS]',
+            'user' => 'vcap',
             'instances' => 2,
             'memory_in_mb' => 1024,
             'disk_in_mb' => 1024,
@@ -1273,6 +1279,7 @@
             },
             'type' => 'worker',
             'command' => '[PRIVATE DATA HIDDEN IN LISTS]',
+            'user' => 'vcap',
             'instances' => 1,
             'memory_in_mb' => 100,
             'disk_in_mb' => 200,
@@ -1401,6 +1408,7 @@
         },
         'type' => 'web',
         'command' => 'rackup',
+        'user' => 'vcap',
         'instances' => 2,
         'memory_in_mb' => 1024,
         'disk_in_mb' => 1024,
@@ -1495,6 +1503,7 @@
 
       update_request = {
         command: 'new command',
+        user: 'containeruser',
         health_check: {
           type: 'http',
           data: {
@@ -1523,6 +1532,7 @@
         },
         'type' => 'web',
         'command' => 'new command',
+        'user' => 'containeruser',
         'instances' => 2,
         'memory_in_mb' => 1024,
         'disk_in_mb' => 1024,
@@ -1570,6 +1580,7 @@
 
       process.reload
       expect(process.command).to eq('new command')
+      expect(process.user).to eq('containeruser')
       expect(process.health_check_type).to eq('http')
       expect(process.health_check_timeout).to eq(20)
       expect(process.health_check_http_endpoint).to eq('/healthcheck')
@@ -1591,6 +1602,7 @@
                                      'process_type' => 'web',
                                      'request' => {
                                        'command' => '[PRIVATE DATA HIDDEN]',
+                                       'user' => 'containeruser',
                                        'health_check' => {
                                          'type' => 'http',
                                          'data' => {
@@ -1652,6 +1664,7 @@
           'revision' => nil
         },
         'command' => 'rackup',
+        'user' => 'vcap',
         'instances' => 5,
         'memory_in_mb' => 10,
         'disk_in_mb' => 20,

spec/unit/actions/deployment_create_spec.rb

@@ -181,6 +181,7 @@ module VCAP::CloudController
             expect(deploying_web_process.state).to eq(ProcessModel::STARTED)
             expect(deploying_web_process.instances).to eq(1)
             expect(deploying_web_process.command).to eq(web_process.command)
+            expect(deploying_web_process.user).to eq(web_process.user)
             expect(deploying_web_process.memory).to eq(web_process.memory)
             expect(deploying_web_process.file_descriptors).to eq(web_process.file_descriptors)
             expect(deploying_web_process.disk_quota).to eq(web_process.disk_quota)