chore(TNZ-44895): start with recreate tests

Author: PeteLevineA

app/models/runtime/deployment_model.rb

@@ -27,7 +27,8 @@ class DeploymentModel < Sequel::Model(:deployments)
 
     DEPLOYMENT_STRATEGIES = [
       ROLLING_STRATEGY = 'rolling'.freeze,
-      CANARY_STRATEGY = 'canary'.freeze
+      CANARY_STRATEGY = 'canary'.freeze,
+      RECREATE_STRATEGY = 'recreate'.freeze
     ].freeze
 
     PROGRESSING_STATES = [

spec/unit/actions/deployment_create_spec.rb

@@ -1509,6 +1509,30 @@ module VCAP::CloudController
           end
         end
 
+        context 'when the strategy is recreate' do
+          let(:strategy) { 'recreate' }
+
+          it 'creates the deployment with the recreate strategy' do
+            deployment = nil
+
+            expect do
+              deployment = DeploymentCreate.create(app:, message:, user_audit_info:)
+            end.to change(DeploymentModel, :count).by(1)
+
+            expect(deployment.strategy).to eq(DeploymentModel::RECREATE_STRATEGY)
+          end
+
+          it 'sets the deployment state to DEPLOYING' do
+            deployment = nil
+
+            expect do
+              deployment = DeploymentCreate.create(app:, message:, user_audit_info:)
+            end.to change(DeploymentModel, :count).by(1)
+
+            expect(deployment.state).to eq(DeploymentModel::DEPLOYING_STATE)
+          end
+        end
+
         context 'when the strategy is nil' do
           let(:strategy) { nil }
 

spec/unit/messages/deployment_create_message_spec.rb

@@ -29,6 +29,12 @@ module VCAP::CloudController
           expect(message).to be_valid
         end
 
+        it 'can be recreate' do
+          body['strategy'] = 'recreate'
+          message = DeploymentCreateMessage.new(body)
+          expect(message).to be_valid
+        end
+
         it 'is valid with nil strategy' do
           body['strategy'] = nil
           message = DeploymentCreateMessage.new(body)
@@ -125,6 +131,15 @@ module VCAP::CloudController
             expect(message).to be_valid
           end
         end
+
+        context 'when set with recreate strategy'
+          it 'is not valid' do
+            body['strategy'] = 'recreate'
+            message = DeploymentCreateMessage.new(body)
+            expect(message).not_to be_valid
+            expect(message.errors.full_messages).to include('Max in flight is not a supported option for recreate deployment strategy')
+          end
+        end
       end
 
       describe 'web_instances' do
@@ -372,6 +387,14 @@ module VCAP::CloudController
           expect(message.errors[:'options.canary']).to include('are only valid for Canary deployments')
         end
 
+        it 'errors when strategy is set to recreate' do
+          body['options'] = { canary: {} }
+          body['strategy'] = 'recreate'
+          message = DeploymentCreateMessage.new(body)
+          expect(message).not_to be_valid
+          expect(message.errors[:'options.canary']).to include('are only valid for Canary deployments')
+        end
+
         it 'errors when there is an unknown option' do
           body['options'] = { foo: 'bar', baz: 'boo' }
           message = DeploymentCreateMessage.new(body)
@@ -486,6 +509,10 @@ module VCAP::CloudController
         end
       end
 
+      describe 'recreate options' do
+        
+      end
+
       describe 'metadata' do
         context 'when the annotations params are valid' do
           let(:params) do

spec/unit/presenters/v3/deployment_presenter_spec.rb

@@ -200,6 +200,16 @@ module VCAP::CloudController::Presenters::V3
             end
           end
         end
+        context 'when the strategy is recreate' do
+          before do
+            deployment.strategy = VCAP::CloudController::DeploymentModel::RECREATE_STRATEGY
+          end
+
+          it 'shows no canary status' do
+            result = DeploymentPresenter.new(deployment).to_hash
+            expect(result[:status][:canary]).to be_nil
+          end
+        end
       end
 
       describe 'options' do