Skip to content

Commit 1054fe7

Browse files
committed
Add more deployment telemetry
1 parent 81e3e18 commit 1054fe7

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

app/actions/deployment_create.rb

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def create(app:, user_audit_info:, message:)
2525

2626
if target_state.rollback_target_revision
2727
revision = RevisionResolver.rollback_app_revision(app, target_state.rollback_target_revision, user_audit_info)
28-
log_rollback_event(app.guid, user_audit_info.user_guid, target_state.rollback_target_revision.guid, message.strategy)
28+
log_rollback_event(app.guid, user_audit_info.user_guid, target_state.rollback_target_revision.guid, message.strategy, message.max_in_flight, message.canary_steps)
2929
else
3030
revision = RevisionResolver.update_app_revision(app, user_audit_info)
3131
end
@@ -251,15 +251,19 @@ def starting_process_instances(deployment, desired_instances)
251251
[deployment.max_in_flight, starting_process_count].min
252252
end
253253

254-
def log_rollback_event(app_guid, user_id, revision_id, strategy)
254+
def log_rollback_event(app_guid, user_id, revision_id, strategy, max_in_flight, canary_steps)
255255
TelemetryLogger.v3_emit(
256256
'rolled-back-app',
257257
{
258258
'app-id' => app_guid,
259259
'user-id' => user_id,
260260
'revision-id' => revision_id
261261
},
262-
{ 'strategy' => strategy }
262+
{
263+
'strategy' => strategy,
264+
'max_in_flight' => max_in_flight,
265+
'canary_steps' => canary_steps
266+
}
263267
)
264268
end
265269
end

app/controllers/v3/deployments_controller.rb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,11 @@ def create
5858
'app-id' => app.guid,
5959
'user-id' => current_user.guid
6060
},
61-
{ 'strategy' => deployment.strategy }
61+
{
62+
'strategy' => deployment.strategy,
63+
'max_in_flight' => deployment.max_in_flight,
64+
'canary_steps' => deployment.canary_steps
65+
}
6266
)
6367
rescue DeploymentCreate::Error => e
6468
unprocessable!(e.message)

0 commit comments

Comments
 (0)