Fix flaky tests related to AsgLatestUpdate (#4021)

Author: svkrieger

spec/unit/actions/security_group_apply_spec.rb

@@ -30,8 +30,9 @@ module VCAP::CloudController
         end
 
         it 'updates the latest security group update table' do
+          last_update = AsgLatestUpdate.last_update
           subject.apply_running(security_group, message, visible_space_guids:, all_spaces_visible:)
-          expect(AsgLatestUpdate.last_update).to be > 1.second.ago
+          expect(AsgLatestUpdate.last_update).to be > last_update
         end
       end
 
@@ -112,8 +113,9 @@ module VCAP::CloudController
         end
 
         it 'updates the latest security group update table' do
+          last_update = AsgLatestUpdate.last_update
           subject.apply_staging(security_group, message, visible_space_guids:, all_spaces_visible:)
-          expect(AsgLatestUpdate.last_update).to be > 1.second.ago
+          expect(AsgLatestUpdate.last_update).to be > last_update
         end
       end
 

spec/unit/actions/security_group_create_spec.rb

@@ -34,8 +34,9 @@ module VCAP::CloudController
           end
 
           it 'updates the latest security group update table' do
+            last_update = AsgLatestUpdate.last_update
             subject.create(message)
-            expect(AsgLatestUpdate.last_update).to be > 1.second.ago
+            expect(AsgLatestUpdate.last_update).to be > last_update
           end
         end
 

spec/unit/actions/security_group_delete_spec.rb

@@ -30,8 +30,9 @@ module VCAP::CloudController
         end
 
         it 'updates the latest security group update table' do
+          last_update = AsgLatestUpdate.last_update
           security_group_delete.delete([security_group])
-          expect(AsgLatestUpdate.last_update).to be > 1.second.ago
+          expect(AsgLatestUpdate.last_update).to be > last_update
         end
 
         it 'deletes associated staging spaces roles' do

spec/unit/actions/security_group_unapply_spec.rb

@@ -23,8 +23,9 @@ module VCAP::CloudController
         end
 
         it 'updates the latest security group update table' do
+          last_update = AsgLatestUpdate.last_update
           subject.unapply_running(security_group, space)
-          expect(AsgLatestUpdate.last_update).to be > 1.second.ago
+          expect(AsgLatestUpdate.last_update).to be > last_update
         end
       end
 
@@ -63,8 +64,9 @@ module VCAP::CloudController
         end
 
         it 'updates the latest security group update table' do
+          last_update = AsgLatestUpdate.last_update
           subject.unapply_staging(security_group, space)
-          expect(AsgLatestUpdate.last_update).to be > 1.second.ago
+          expect(AsgLatestUpdate.last_update).to be > last_update
         end
       end
 

spec/unit/actions/security_group_update_spec.rb

@@ -39,8 +39,9 @@ module VCAP::CloudController
         end
 
         it 'updates the latest security group update table' do
+          last_update = AsgLatestUpdate.last_update
           SecurityGroupUpdate.update(security_group, update_message)
-          expect(AsgLatestUpdate.last_update).to be > 1.second.ago
+          expect(AsgLatestUpdate.last_update).to be > last_update
         end
       end
 

spec/unit/models/runtime/asg_latest_update_spec.rb

@@ -11,8 +11,9 @@ module VCAP::CloudController
 
       context 'when there is no previous update' do
         it 'creates an asgLatestUpdate' do
+          last_update = AsgLatestUpdate.last_update
           AsgLatestUpdate.renew
-          expect(AsgLatestUpdate.last_update).to be > 1.second.ago
+          expect(AsgLatestUpdate.last_update).to be > last_update
         end
       end
     end