build(deps-dev): bump rubocop from 1.79.2 to 1.80.0 (#4531)

* build(deps-dev): bump rubocop from 1.79.2 to 1.80.0

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.79.2 to 1.80.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.79.2...v1.80.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-version: 1.80.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix rubocop errors

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: M. Oleske <[email protected]>

Author: dependabot[bot]

Gemfile

@@ -84,7 +84,7 @@ group :test do
   gem 'rspec-its'
   gem 'rspec-rails', '~> 8.0.2'
   gem 'rspec-wait'
-  gem 'rubocop', '~> 1.79.2'
+  gem 'rubocop', '~> 1.80.0'
   gem 'rubocop-capybara'
   gem 'rubocop-factory_bot'
   gem 'rubocop-rails', '~> 2.33'

Gemfile.lock

@@ -480,7 +480,7 @@ GEM
       activesupport (>= 3.0.0)
       mustache (~> 1.0, >= 0.99.4)
       rspec (~> 3.0)
-    rubocop (1.79.2)
+    rubocop (1.80.0)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -595,7 +595,7 @@ GEM
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     uber (0.1.0)
-    unicode-display_width (3.1.4)
+    unicode-display_width (3.1.5)
       unicode-emoji (~> 4.0, >= 4.0.4)
     unicode-emoji (4.0.4)
     uri (1.0.3)
@@ -685,7 +685,7 @@ DEPENDENCIES
   rspec-rails (~> 8.0.2)
   rspec-wait
   rspec_api_documentation (>= 6.1.0)
-  rubocop (~> 1.79.2)
+  rubocop (~> 1.80.0)
   rubocop-capybara
   rubocop-factory_bot
   rubocop-rails (~> 2.33)

app/actions/app_apply_manifest.rb

@@ -136,7 +136,7 @@ def validate_name_dns_compliant!(name)
 
       error!(prefix + ' Host cannot exceed 63 characters') if name.present? && name.length > 63
 
-      return if name&.match(/\A[\w\-]+\z/)
+      return if name&.match(/\A[\w-]+\z/)
 
       error!(prefix + ' Host must be either "*" or contain only alphanumeric characters, "_", or "-"')
     end

app/messages/domain_create_message.rb

@@ -45,7 +45,7 @@ def self.relationships_requested?
 
     validates :name,
               format: {
-                with: /\A^([^\.]{0,63}\.)*[^\.]{0,63}$\Z/,
+                with: /\A^([^.]{0,63}\.)*[^.]{0,63}$\Z/,
                 message: 'subdomains must each be at most 63 characters'
               }
 
@@ -74,7 +74,7 @@ def router_group_guid
     private
 
     def alpha_numeric
-      return unless /[^a-z0-9\-\.]/i.match?(name.to_s)
+      return unless /[^a-z0-9\-.]/i.match?(name.to_s)
 
       errors.add(:name, 'must consist of alphanumeric characters and hyphens')
     end

app/messages/metadata_validator_helper.rb

@@ -8,7 +8,7 @@ class MetadataValidatorHelper
     MAX_METADATA_KEY_SIZE = 63
     MAX_METADATA_PREFIX_SIZE = 253
 
-    INVALID_CHAR_REGEX = /[^\w\-\.]/
+    INVALID_CHAR_REGEX = /[^\w\-.]/
     ALPHANUMERIC_START_END_REGEX = /\A(?=[a-zA-Z\d]).*[a-zA-Z\d]\z/
 
     RESERVED_DOMAIN = 'cloudfoundry.org'.freeze

app/messages/route_create_message.rb

@@ -25,7 +25,7 @@ def self.options_requested?
                 maximum: MAXIMUM_DOMAIN_LABEL_LENGTH
               },
               format: {
-                with: /\A([\w\-]+|\*)?\z/,
+                with: /\A([\w-]+|\*)?\z/,
                 message: 'must be either "*" or contain only alphanumeric characters, "_", or "-"'
               }
 

app/models/helpers/metadata_helpers.rb

@@ -2,7 +2,7 @@ module VCAP::CloudController
   class MetadataHelpers
     KEY_SEPARATOR = '/'.freeze
     REQUIREMENT_SPLITTER = /(?:\(.*?\)|[^,])+/
-    KEY_CHARACTERS = %r{[\w\-\.\_\/]+}
+    KEY_CHARACTERS = %r{[\w\-._/]+}
 
     IN_PATTERN = /\A(?<key>.*?) in \((?<values>.*)\)\z/                     # foo in (bar,baz)
     NOT_IN_PATTERN = /\A(?<key>.*?) notin \((?<values>.*)\)\z/              # funky notin (uptown,downtown)

app/models/runtime/route.rb

@@ -109,7 +109,7 @@ def validate
 
       errors.add(:host, :presence) if host.nil?
 
-      validates_format(/\A([\w\-]+|\*)\z/, :host) if host && !host.empty?
+      validates_format(/\A([\w-]+|\*)\z/, :host) if host && !host.empty?
 
       validate_uniqueness_on_host_and_domain if path.empty? && port.nil?
       validate_uniqueness_on_host_domain_and_port if path.empty?

lib/cloud_controller/domain_decorator.rb

@@ -1,6 +1,6 @@
 module CloudController
   class DomainDecorator
-    DOMAIN_REGEX = /\A(([a-z0-9]|[a-z0-9][a-z0-9\-]{0,61}[a-z0-9])\.)+([a-z0-9]|[a-z0-9][a-z0-9\-]{0,61}[a-z0-9])\Z/ix
+    DOMAIN_REGEX = /\A(([a-z0-9]|[a-z0-9][a-z0-9-]{0,61}[a-z0-9])\.)+([a-z0-9]|[a-z0-9][a-z0-9-]{0,61}[a-z0-9])\Z/ix
     DOMAIN_DELIMITER = '.'.freeze
 
     attr_reader :name

lib/utils/uri_utils.rb

@@ -4,8 +4,8 @@ module UriUtils
   SSH_REGEX = %r{ \A (?:ssh://)? git@ .+? : .+? \.git \z }x
   GIT_REGEX = %r{ \A git:// .+? : .+? \.git \z }x
   DOCKER_INDEX_SERVER = 'docker.io'.freeze
-  DOCKER_PATH_REGEX = %r{\A[a-z0-9_\-\.\/]{2,255}\Z}
-  DOCKER_TAG_REGEX = /[a-zA-Z0-9_\-\.]{1,128}/
+  DOCKER_PATH_REGEX = %r{\A[a-z0-9_\-./]{2,255}\Z}
+  DOCKER_TAG_REGEX = /[a-zA-Z0-9_\-.]{1,128}/
   DOCKER_DIGEST_REGEX = /sha256:[a-z0-9]{64}/
   DOCKER_TAG_DIGEST_REGEX = Regexp.new("\\A(#{DOCKER_TAG_REGEX.source} |
 (#{DOCKER_TAG_REGEX.source}@#{DOCKER_DIGEST_REGEX.source}) | #{DOCKER_DIGEST_REGEX.source})\\Z", Regexp::EXTENDED)
@@ -36,7 +36,7 @@ def self.is_cnb_buildpack_uri?(candidate)
   end
 
   def self.is_uri_path?(candidate)
-    !!(candidate.is_a?(String) && candidate =~ %r{^(?:/|/([^\s/][\S]*)?)$})
+    !!(candidate.is_a?(String) && candidate =~ %r{^(?:/|/([^\s/]\S*)?)$})
   end
 
   # This escapes only the values in queries.