build(deps): bump httpclient from 2.8.3 to 2.9.0 (#4233)

* build(deps): bump httpclient from 2.8.3 to 2.9.0

Bumps [httpclient](https://github.com/nahi/httpclient) from 2.8.3 to 2.9.0.
- [Changelog](https://github.com/nahi/httpclient/blob/master/CHANGELOG.md)
- [Commits](nahi/httpclient@v2.8.3...v2.9.0)

---
updated-dependencies:
- dependency-name: httpclient
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Adapt Credhub::Client spec

Method cert_store_items is only available for JRuby now, thus checking
the configured credhub_ca.crt using a spy on OpenSSL::X509::Store
instead.

* Adapt HTTPClient version in spec

Method create_socket in HTTPClient::Session has not been changed in
2.9.0 thus the monkey patch still works.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Philipp Thun <[email protected]>

Author: dependabot[bot]

Gemfile.lock

@@ -261,7 +261,8 @@ GEM
     http-cookie (1.0.5)
       domain_name (~> 0.5)
     http-form_data (2.3.0)
-    httpclient (2.8.3)
+    httpclient (2.9.0)
+      mutex_m
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
     io-console (0.8.0)

spec/unit/lib/credhub/client_spec.rb

@@ -14,8 +14,9 @@ module Credhub
     describe '#client' do
       describe 'ssl_config' do
         it 'uses the configured credhub_ca.crt' do
-          expect(subject.send(:client).ssl_config.cert_store_items).
-            to include(TestConfig.config_instance.get(:credhub_api, :ca_cert_path))
+          expect_any_instance_of(OpenSSL::X509::Store).to receive(:add_file).with(TestConfig.config_instance.get(:credhub_api, :ca_cert_path)).exactly(:once)
+
+          subject.send(:build_client)
         end
       end
     end

spec/unit/lib/http/httpclient_spec.rb

@@ -3,7 +3,7 @@
 RSpec.describe HTTPClient do
   describe 'version' do
     it 'is not updated' do
-      expect(HTTPClient::VERSION).to eq('2.8.3'), 'revisit monkey patch in lib/http/httpclient.rb'
+      expect(HTTPClient::VERSION).to eq('2.9.0'), 'revisit monkey patch in lib/http/httpclient.rb'
     end
   end