Rename allowed_process_users to additional_allowed_process_users

Author: tcdowney

app/models/runtime/process_model.rb

@@ -573,7 +573,7 @@ def open_ports
     private
 
     def permitted_users
-      Set.new([DEFAULT_USER]) + Config.config.get(:allowed_process_users)
+      Set.new([DEFAULT_USER]) + Config.config.get(:additional_allowed_process_users)
     end
 
     def docker_run_action_user

config/cloud_controller.yml

@@ -67,7 +67,7 @@ maximum_app_disk_in_mb: 2048
 max_retained_deployments_per_app: 100
 max_retained_builds_per_app: 100
 max_retained_revisions_per_app: 100
-allowed_process_users: ['ContainerUser']
+additional_allowed_process_users: ['ContainerUser']
 
 broker_client_default_async_poll_interval_seconds: 60
 broker_client_max_async_poll_duration_minutes: 10080

lib/cloud_controller/config_schemas/base/api_schema.rb

@@ -45,7 +45,7 @@ class ApiSchema < VCAP::Config
             maximum_app_disk_in_mb: Integer,
             default_health_check_timeout: Integer,
             maximum_health_check_timeout: Integer,
-            optional(:allowed_process_users) => Array,
+            optional(:additional_allowed_process_users) => Array,
 
             instance_file_descriptor_limit: Integer,
 

lib/cloud_controller/config_schemas/base/clock_schema.rb

@@ -157,7 +157,7 @@ class ClockSchema < VCAP::Config
             max_retained_deployments_per_app: Integer,
             max_retained_builds_per_app: Integer,
             max_retained_revisions_per_app: Integer,
-            optional(:allowed_process_users) => Array,
+            optional(:additional_allowed_process_users) => Array,
 
             diego_sync: { frequency_in_seconds: Integer },
 

lib/cloud_controller/config_schemas/base/deployment_updater_schema.rb

@@ -58,7 +58,7 @@ class DeploymentUpdaterSchema < VCAP::Config
             default_app_disk_in_mb: Integer,
             maximum_app_disk_in_mb: Integer,
             instance_file_descriptor_limit: Integer,
-            optional(:allowed_process_users) => Array,
+            optional(:additional_allowed_process_users) => Array,
 
             deployment_updater: {
               update_frequency_in_seconds: Integer,

lib/cloud_controller/config_schemas/base/worker_schema.rb

@@ -167,7 +167,7 @@ class WorkerSchema < VCAP::Config
             maximum_app_disk_in_mb: Integer,
             default_app_log_rate_limit_in_bytes_per_second: Integer,
             default_app_ssh_access: bool,
-            optional(:allowed_process_users) => Array,
+            optional(:additional_allowed_process_users) => Array,
 
             jobs: {
               global: {

spec/unit/models/runtime/process_model_spec.rb

@@ -337,12 +337,12 @@ def expect_no_validator(validator_class)
         let(:process_user) { 'vcap' }
 
         before do
-          TestConfig.override(allowed_process_users: %w[some_user some_other_user])
+          TestConfig.override(additional_allowed_process_users: %w[some_user some_other_user])
         end
 
         context 'when user is vcap' do
           before do
-            TestConfig.override(allowed_process_users: [])
+            TestConfig.override(additional_allowed_process_users: [])
           end
 
           it 'is always permitted' do