build(deps-dev): bump rubocop-rails from 2.29.1 to 2.30.3 (#4300)

* build(deps-dev): bump rubocop-rails from 2.29.1 to 2.30.3

Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.29.1 to 2.30.3.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.29.1...v2.30.3)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-version: 2.30.3
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Run rubocop autocorrect

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: M. Oleske <[email protected]>

Author: dependabot[bot]

Gemfile

@@ -86,7 +86,7 @@ group :test do
   gem 'rubocop', '~> 1.75.2'
   gem 'rubocop-capybara'
   gem 'rubocop-factory_bot'
-  gem 'rubocop-rails', '~> 2.29'
+  gem 'rubocop-rails', '~> 2.30'
   gem 'rubocop-rspec', '~> 3.4'
   gem 'rubocop-rspec_rails'
   gem 'rubocop-sequel', '~> 0.4.1'

Gemfile.lock

@@ -311,7 +311,7 @@ GEM
     mime-types-data (3.2025.0318)
     mini_mime (1.1.5)
     mini_portile2 (2.8.8)
-    minitest (5.25.4)
+    minitest (5.25.5)
     mock_redis (0.49.0)
       redis (~> 5)
     ms_rest (0.6.4)
@@ -489,11 +489,12 @@ GEM
     rubocop-factory_bot (2.27.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
-    rubocop-rails (2.29.1)
+    rubocop-rails (2.30.3)
       activesupport (>= 4.2.0)
+      lint_roller (~> 1.1)
       rack (>= 1.1)
-      rubocop (>= 1.52.0, < 2.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
+      rubocop (>= 1.72.1, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
     rubocop-rspec (3.5.0)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
@@ -673,7 +674,7 @@ DEPENDENCIES
   rubocop (~> 1.75.2)
   rubocop-capybara
   rubocop-factory_bot
-  rubocop-rails (~> 2.29)
+  rubocop-rails (~> 2.30)
   rubocop-rspec (~> 3.4)
   rubocop-rspec_rails
   rubocop-sequel (~> 0.4.1)

app/presenters/error_presenter.rb

@@ -29,9 +29,7 @@ def to_hash
     end
   end
 
-  def api_error?
-    @error_hasher.api_error?
-  end
+  delegate :api_error?, to: :@error_hasher
 
   private
 

app/presenters/system_environment/service_instance_presenter.rb

@@ -7,9 +7,7 @@ def initialize(service_instance)
                  end
   end
 
-  def to_hash
-    @presenter.to_hash
-  end
+  delegate :to_hash, to: :@presenter
 
   class ProvidedPresenter
     def initialize(service_instance)

lib/cloud_controller/errors/instances_unavailable.rb

@@ -5,9 +5,7 @@ def initialize(wrapped_exception)
         @wrapped_exception = wrapped_exception
       end
 
-      def to_s
-        @wrapped_exception.to_s
-      end
+      delegate :to_s, to: :@wrapped_exception
     end
   end
 end

lib/cloud_controller/errors/no_running_instances.rb

@@ -5,9 +5,7 @@ def initialize(wrapped_exception)
         @wrapped_exception = wrapped_exception
       end
 
-      def to_s
-        @wrapped_exception.to_s
-      end
+      delegate :to_s, to: :@wrapped_exception
     end
   end
 end

lib/cloud_controller/security/access_context.rb

@@ -15,9 +15,7 @@ def admin_override
         VCAP::CloudController::SecurityContext.admin? || VCAP::CloudController::SecurityContext.admin_read_only? || VCAP::CloudController::SecurityContext.global_auditor?
       end
 
-      def roles
-        VCAP::CloudController::SecurityContext.roles
-      end
+      delegate :roles, to: :'VCAP::CloudController::SecurityContext'
 
       def user_email
         VCAP::CloudController::SecurityContext.current_user_email

lib/sequel_plugins/vcap_serialization.rb

@@ -37,9 +37,7 @@ def export_attrs
       self.class.export_attrs || []
     end
 
-    def export_attrs_from_methods
-      self.class.export_attrs_from_methods
-    end
+    delegate :export_attrs_from_methods, to: :class
 
     # Update the model instance from the supplied json string.  Only update
     # attributes specified by import_attributes.

lib/services/sso/uaa/uaa_client_manager.rb

@@ -10,9 +10,7 @@ def initialize(opts={})
       @uaa_client = create_uaa_client
     end
 
-    def get_clients(client_ids)
-      @uaa_client.get_clients(client_ids)
-    end
+    delegate :get_clients, to: :@uaa_client
 
     def modify_transaction(changeset)
       return if changeset.empty?