Skip to content

Commit 2f67f92

Browse files
sethboylessethboyles
committed
more keyword argument fixes
1 parent c2d8d55 commit 2f67f92

23 files changed

+101
-101
lines changed

‎spec/request/apps_spec.rb

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1952,7 +1952,7 @@
19521952
end
19531953

19541954
let(:expected_codes_and_responses) do
1955-
h = Hash.new(code: 200)
1955+
h = Hash.new({code: 200})
19561956
h['org_auditor'] = { code: 404 }
19571957
h['org_billing_manager'] = { code: 404 }
19581958
h['no_role'] = { code: 404 }
@@ -2005,7 +2005,7 @@
20052005
context 'permissions for deleting an app' do
20062006
let(:api_call) { ->(user_headers) { delete "/v3/apps/#{app_model.guid}", nil, user_headers } }
20072007
let(:expected_codes_and_responses) do
2008-
h = Hash.new(code: 202)
2008+
h = Hash.new({code: 202})
20092009
%w[admin_read_only global_auditor org_manager space_auditor space_manager space_supporter].each do |r|
20102010
h[r] = { code: 403, errors: CF_NOT_AUTHORIZED }
20112011
end
@@ -2229,7 +2229,7 @@
22292229
context 'permissions for updating an app' do
22302230
let(:api_call) { ->(user_headers) { patch "/v3/apps/#{app_model.guid}", update_request.to_json, user_headers } }
22312231
let(:expected_codes_and_responses) do
2232-
h = Hash.new(code: 200, response_object: expected_response_object)
2232+
h = Hash.new({code: 200, response_object: expected_response_object})
22332233
%w[admin_read_only global_auditor org_manager space_auditor space_manager space_supporter].each do |r|
22342234
h[r] = { code: 403, errors: CF_NOT_AUTHORIZED }
22352235
end
@@ -2359,7 +2359,7 @@
23592359
end
23602360

23612361
let(:expected_codes_and_responses) do
2362-
h = Hash.new(code: 403, errors: CF_NOT_AUTHORIZED)
2362+
h = Hash.new({code: 403, errors: CF_NOT_AUTHORIZED})
23632363
h['no_role'] = { code: 404 }
23642364
h['org_auditor'] = { code: 404 }
23652365
h['org_billing_manager'] = { code: 404 }
@@ -2699,7 +2699,7 @@
26992699
end
27002700

27012701
let(:expected_codes_and_responses) do
2702-
h = Hash.new(code: 403, errors: CF_NOT_AUTHORIZED)
2702+
h = Hash.new({code: 403, errors: CF_NOT_AUTHORIZED})
27032703
h['no_role'] = { code: 404 }
27042704
h['org_auditor'] = { code: 404 }
27052705
h['org_billing_manager'] = { code: 404 }
@@ -2868,7 +2868,7 @@
28682868
end
28692869

28702870
let(:expected_codes_and_responses) do
2871-
h = Hash.new(code: 403, errors: CF_NOT_AUTHORIZED)
2871+
h = Hash.new({code: 403, errors: CF_NOT_AUTHORIZED})
28722872
h['no_role'] = { code: 404 }
28732873
h['org_auditor'] = { code: 404 }
28742874
h['org_billing_manager'] = { code: 404 }
@@ -2953,7 +2953,7 @@
29532953
end
29542954

29552955
let(:expected_codes_and_responses) do
2956-
h = Hash.new(code: 200, response_object: expected_response)
2956+
h = Hash.new({code: 200, response_object: expected_response})
29572957
h['no_role'] = { code: 404 }
29582958
h['org_billing_manager'] = { code: 404 }
29592959
h['org_auditor'] = { code: 404 }
@@ -3016,7 +3016,7 @@
30163016
}
30173017
end
30183018
let(:expected_codes_and_responses) do
3019-
h = Hash.new(code: 200, response_object: expected_response)
3019+
h = Hash.new({code: 200, response_object: expected_response})
30203020
h['no_role'] = { code: 404 }
30213021
h['org_billing_manager'] = { code: 404 }
30223022
h['org_auditor'] = { code: 404 }
@@ -3074,7 +3074,7 @@
30743074
end
30753075

30763076
let(:expected_codes_and_responses) do
3077-
h = Hash.new(code: 403, errors: CF_NOT_AUTHORIZED)
3077+
h = Hash.new({code: 403, errors: CF_NOT_AUTHORIZED})
30783078
h['no_role'] = { code: 404 }
30793079
h['org_auditor'] = { code: 404 }
30803080
h['org_billing_manager'] = { code: 404 }
@@ -3294,7 +3294,7 @@
32943294
}
32953295
end
32963296
let(:expected_codes_and_responses) do
3297-
h = Hash.new(code: 404)
3297+
h = Hash.new({code: 404})
32983298
%w[global_auditor admin_read_only org_manager space_auditor space_manager].each do |r|
32993299
h[r] = { code: 403, errors: CF_NOT_AUTHORIZED }
33003300
end
@@ -3343,7 +3343,7 @@
33433343

33443344
it_behaves_like 'permissions for single object endpoint', ALL_PERMISSIONS do
33453345
let(:expected_codes_and_responses) do
3346-
h = Hash.new(code: 404)
3346+
h = Hash.new({code: 404})
33473347
h['global_auditor'] = h['org_manager'] = h['space_auditor'] = h['space_manager'] = { code: 403 }
33483348
h['admin'] = h['admin_read_only'] = h['space_developer'] = h['space_supporter'] = {
33493349
code: 200,
@@ -3360,7 +3360,7 @@
33603360

33613361
it_behaves_like 'permissions for single object endpoint', ALL_PERMISSIONS do
33623362
let(:expected_codes_and_responses) do
3363-
h = Hash.new(code: 404)
3363+
h = Hash.new({code: 404})
33643364
h['global_auditor'] = h['org_manager'] = h['space_auditor'] = h['space_manager'] = h['space_developer'] = h['space_supporter'] = { code: 403 }
33653365
h['admin'] = h['admin_read_only'] = {
33663366
code: 200,
@@ -3393,7 +3393,7 @@
33933393
end
33943394

33953395
let(:expected_codes_and_responses) do
3396-
h = Hash.new(code: 404)
3396+
h = Hash.new({code: 404})
33973397
h['admin'] = { code: 200, response_object: read_all_response }
33983398
h['admin_read_only'] = { code: 200, response_object: read_all_response }
33993399
h['global_auditor'] = { code: 200, response_object: read_basic_response }

‎spec/request/environment_variable_groups_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
let(:org) { VCAP::CloudController::Organization.make }
7878
let(:space) { VCAP::CloudController::Space.make(organization: org) }
7979
let(:api_call) { ->(user_headers) { get '/v3/environment_variable_groups/running', nil, user_headers } }
80-
let(:expected_codes_and_responses) { Hash.new(code: 200) }
80+
let(:expected_codes_and_responses) { Hash.new({code: 200}) }
8181

8282
before do
8383
space.organization.add_user(user)
@@ -193,7 +193,7 @@
193193
end
194194

195195
let(:expected_codes_and_responses) do
196-
h = Hash.new(code: 403)
196+
h = Hash.new({code: 403})
197197
h['admin'] = { code: 200, response_object: env_group_json }
198198
h
199199
end

‎spec/request/isolation_segments_spec.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@
8888
let(:user) { VCAP::CloudController::User.make }
8989

9090
let(:expected_codes_and_responses) do
91-
h = Hash.new(code: 200, response_guids: [org1.guid, org2.guid, space.organization.guid])
91+
h = Hash.new({code: 200, response_guids: [org1.guid, org2.guid, space.organization.guid]})
9292
h['org_auditor'] = { code: 200, response_guids: [space.organization.guid] }
9393
h['org_billing_manager'] = { code: 200, response_guids: [space.organization.guid] }
9494
h['org_manager'] = { code: 200, response_guids: [space.organization.guid] }
@@ -136,7 +136,7 @@
136136
let(:user) { VCAP::CloudController::User.make }
137137

138138
let(:expected_codes_and_responses) do
139-
h = Hash.new(code: 200, response_guids: [space1.guid, space2.guid])
139+
h = Hash.new({code: 200, response_guids: [space1.guid, space2.guid]})
140140
h['org_auditor'] = { code: 200, response_guids: [] }
141141
h['org_billing_manager'] = { code: 200, response_guids: [] }
142142
h['org_manager'] = { code: 200, response_guids: [space1.guid] }
@@ -230,7 +230,7 @@
230230
let(:org) { space.organization }
231231
let(:user) { VCAP::CloudController::User.make }
232232
let(:expected_codes_and_responses) do
233-
h = Hash.new(code: 200, response_object: expected_response_object)
233+
h = Hash.new({code: 200, response_object: expected_response_object})
234234
h['no_role'] = { code: 404 }
235235
h
236236
end
@@ -243,7 +243,7 @@
243243
let(:org) { space.organization }
244244
let(:user) { VCAP::CloudController::User.make }
245245
let(:expected_codes_and_responses) do
246-
h = Hash.new(code: 404)
246+
h = Hash.new({code: 404})
247247
h['admin'] = { code: 200, response_object: expected_response_object }
248248
h['admin_read_only'] = { code: 200, response_object: expected_response_object }
249249
h['global_auditor'] = { code: 200, response_object: expected_response_object }
@@ -485,7 +485,7 @@
485485
let(:org) { space.organization }
486486
let(:user) { VCAP::CloudController::User.make }
487487
let(:expected_codes_and_responses) do
488-
h = Hash.new(code: 200, response_guids: [iso_seg1.guid])
488+
h = Hash.new({code: 200, response_guids: [iso_seg1.guid]})
489489
h['admin'] = { code: 200, response_guids: [iso_seg1.guid, VCAP::CloudController::IsolationSegmentModel::SHARED_ISOLATION_SEGMENT_GUID] }
490490
h['admin_read_only'] = { code: 200, response_guids: [iso_seg1.guid, VCAP::CloudController::IsolationSegmentModel::SHARED_ISOLATION_SEGMENT_GUID] }
491491
h['global_auditor'] = { code: 200, response_guids: [iso_seg1.guid, VCAP::CloudController::IsolationSegmentModel::SHARED_ISOLATION_SEGMENT_GUID] }

‎spec/request/jobs_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ def display_name
167167

168168
context 'when the user has a global scope or a local role' do
169169
let(:api_call) { ->(user_headers) { get "/v3/jobs/#{job.guid}", nil, user_headers } }
170-
let(:expected_codes_and_responses) { Hash.new(code: 200) }
170+
let(:expected_codes_and_responses) { Hash.new({code: 200}) }
171171

172172
before do
173173
space.organization.add_user(user)

‎spec/request/route_destinations_spec.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -157,10 +157,10 @@
157157

158158
context 'when the user is a member in the routes org' do
159159
let(:expected_codes_and_responses) do
160-
h = Hash.new(
160+
h = Hash.new({
161161
code: 200,
162162
response_object: response_json
163-
)
163+
})
164164

165165
h['org_billing_manager'] = { code: 404 }
166166
h['no_role'] = { code: 404 }
@@ -291,7 +291,7 @@
291291
end
292292

293293
let(:expected_codes_and_responses) do
294-
h = Hash.new(code: 403, errors: CF_NOT_AUTHORIZED)
294+
h = Hash.new({code: 403, errors: CF_NOT_AUTHORIZED})
295295
h['admin'] = { code: 200, response_object: response_json }
296296
h['space_developer'] = { code: 200, response_object: response_json }
297297
h['space_supporter'] = { code: 200, response_object: response_json }
@@ -801,7 +801,7 @@
801801
}
802802
end
803803
let(:expected_codes_and_responses) do
804-
h = Hash.new(code: 403, errors: CF_NOT_AUTHORIZED)
804+
h = Hash.new({code: 403, errors: CF_NOT_AUTHORIZED})
805805
h['admin'] = { code: 200, response_object: response_json }
806806
h['space_developer'] = { code: 200, response_object: response_json }
807807
h['space_supporter'] = { code: 200, response_object: response_json }
@@ -1244,7 +1244,7 @@
12441244
end
12451245

12461246
let(:expected_codes_and_responses) do
1247-
h = Hash.new(code: 403, errors: CF_NOT_AUTHORIZED)
1247+
h = Hash.new({code: 403, errors: CF_NOT_AUTHORIZED})
12481248
h['admin'] = { code: 200 }
12491249
h['space_developer'] = { code: 200 }
12501250
h['space_supporter'] = { code: 200 }
@@ -1367,7 +1367,7 @@
13671367
end
13681368

13691369
let(:expected_codes_and_responses) do
1370-
h = Hash.new(code: 403, errors: CF_NOT_AUTHORIZED)
1370+
h = Hash.new({code: 403, errors: CF_NOT_AUTHORIZED})
13711371
h['admin'] = { code: 204 }
13721372
h['space_developer'] = { code: 204 }
13731373
h['space_supporter'] = { code: 204 }

‎spec/request/routes_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2675,7 +2675,7 @@
26752675
describe 'permissions' do
26762676
it_behaves_like 'permissions for single object endpoint', ALL_PERMISSIONS do
26772677
let(:expected_codes_and_responses) do
2678-
h = Hash.new(code: 200, response_object: {
2678+
h = Hash.new({code: 200, response_object: {
26792679
data: [
26802680
{
26812681
guid: target_space_1.guid
@@ -2684,7 +2684,7 @@
26842684
links: {
26852685
self: { href: %r{#{Regexp.escape(link_prefix)}/v3/routes/#{route.guid}/relationships/shared_spaces} }
26862686
}
2687-
})
2687+
}})
26882688

26892689
h['org_billing_manager'] = { code: 404 }
26902690
h['no_role'] = { code: 404 }

‎spec/request/service_credential_bindings_spec.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,10 @@
114114
end
115115

116116
let(:expected_codes_and_responses) do
117-
Hash.new(
117+
Hash.new({
118118
code: 200,
119119
response_objects: []
120-
).tap do |h|
120+
}).tap do |h|
121121
h['admin'] = all_bindings
122122
h['admin_read_only'] = all_bindings
123123
h['global_auditor'] = all_bindings
@@ -506,7 +506,7 @@ def check_filtered_bindings(*bindings)
506506
let(:api_call) { ->(user_headers) { get '/v3/service_credential_bindings/no-binding', nil, user_headers } }
507507

508508
let(:expected_codes_and_responses) do
509-
Hash.new(code: 404)
509+
Hash.new({code: 404})
510510
end
511511

512512
it_behaves_like 'permissions for single object endpoint', ALL_PERMISSIONS
@@ -721,7 +721,7 @@ def check_filtered_bindings(*bindings)
721721
context 'permissions' do
722722
it_behaves_like 'permissions for single object endpoint', ALL_PERMISSIONS do
723723
let(:expected_codes_and_responses) do
724-
h = Hash.new(code: 404, response_object: binding_credentials)
724+
h = Hash.new({code: 404, response_object: binding_credentials})
725725
h['admin'] = h['admin_read_only'] = h['space_developer'] = { code: 200 }
726726
h
727727
end
@@ -2428,7 +2428,7 @@ def check_filtered_bindings(*bindings)
24282428
end
24292429

24302430
let(:expected_codes_and_responses) do
2431-
h = Hash.new(code: 404)
2431+
h = Hash.new({code: 404})
24322432
h['admin'] = { code: 202 }
24332433
h['admin_read_only'] = h['global_auditor'] = { code: 403 }
24342434
h

‎spec/request/service_instances_spec.rb

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
let(:guid) { 'no-such-guid' }
1717

1818
let(:expected_codes_and_responses) do
19-
Hash.new(code: 404)
19+
Hash.new({code: 404})
2020
end
2121

2222
it_behaves_like 'permissions for single object endpoint', ALL_PERMISSIONS
@@ -247,10 +247,10 @@
247247
end
248248

249249
let(:expected_codes_and_responses) do
250-
h = Hash.new(
250+
h = Hash.new({
251251
code: 200,
252252
response_objects: []
253-
)
253+
})
254254

255255
h['admin'] = all_instances
256256
h['admin_read_only'] = all_instances
@@ -526,10 +526,10 @@ def check_filtered_instances(*instances)
526526
let(:guid) { instance.guid }
527527

528528
let(:expected_codes_and_responses) do
529-
h = Hash.new(
529+
h = Hash.new({
530530
code: 200,
531531
response_object: credentials
532-
)
532+
})
533533

534534
h['global_auditor'] = h['space_supporter'] = h['space_manager'] = h['space_auditor'] = h['org_manager'] = { code: 403 }
535535
h['org_auditor'] = h['org_billing_manager'] = h['no_role'] = { code: 404 }
@@ -593,10 +593,10 @@ def check_filtered_instances(*instances)
593593
let(:guid) { instance.guid }
594594

595595
let(:expected_codes_and_responses) do
596-
h = Hash.new(
596+
h = Hash.new({
597597
code: 200,
598598
response_object: parameters
599-
)
599+
})
600600

601601
h['org_auditor'] = { code: 404 }
602602
h['org_billing_manager'] = { code: 404 }
@@ -702,10 +702,10 @@ def check_filtered_instances(*instances)
702702
end
703703

704704
let(:expected_codes_and_responses) do
705-
h = Hash.new(
705+
h = Hash.new({
706706
code: 200,
707707
response_object: parameters
708-
)
708+
})
709709

710710
h['space_supporter'] = h['space_developer'] = h['space_manager'] = h['space_auditor'] = h['org_manager'] = { code: 403 }
711711
h['org_auditor'] = h['org_billing_manager'] = h['no_role'] = { code: 404 }
@@ -4237,7 +4237,7 @@ def create_bindings(instance, space:, count:)
42374237
let(:guid) { 'no-such-guid' }
42384238

42394239
let(:expected_codes_and_responses) do
4240-
h = Hash.new(code: 404)
4240+
h = Hash.new({code: 404})
42414241
h['unauthenticated'] = { code: 401 }
42424242
h
42434243
end
@@ -4250,7 +4250,7 @@ def create_bindings(instance, space:, count:)
42504250
let(:guid) { instance.guid }
42514251

42524252
let(:expected_codes_and_responses) do
4253-
h = Hash.new(code: 404)
4253+
h = Hash.new({code: 404})
42544254
%w[admin space_developer].each { |r| h[r] = READ_AND_WRITE }
42554255
%w[admin_read_only global_auditor org_manager space_manager space_auditor space_supporter].each { |r| h[r] = READ_ONLY }
42564256
%w[org_billing_manager org_auditor no_role service_permissions_reader].each { |r| h[r] = NO_PERMISSIONS }
@@ -4299,7 +4299,7 @@ def create_bindings(instance, space:, count:)
42994299
let(:guid) { instance.guid }
43004300

43014301
let(:expected_codes_and_responses) do
4302-
h = Hash.new(code: 404)
4302+
h = Hash.new({code: 404})
43034303
h['admin'] = READ_AND_WRITE
43044304
%w[admin_read_only global_auditor].each { |r| h[r] = READ_ONLY }
43054305
%w[org_billing_manager org_auditor org_manager space_manager space_auditor space_developer space_supporter no_role service_permissions_reader].each do |r|

0 commit comments

Comments
 (0)