build(deps-dev): bump rubocop-rspec from 3.3.0 to 3.4.0 (#4180)

* build(deps-dev): bump rubocop-rspec from 3.3.0 to 3.4.0

Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rspec@v3.3.0...v3.4.0)

---
updated-dependencies:
- dependency-name: rubocop-rspec
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Remove obsolete cop

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Philipp Thun <[email protected]>

Author: dependabot[bot]

.rubocop_cc.yml

@@ -560,8 +560,6 @@ RSpec/SpecFilePathFormat:
   Enabled: true
 RSpec/SpecFilePathSuffix:
   Enabled: true
-RSpec/StringAsInstanceDoubleConstant:
-  Enabled: true
 RSpec/SubjectDeclaration:
   Enabled: true
 RSpec/VerifiedDoubleReference:

Gemfile

@@ -87,7 +87,7 @@ group :test do
   gem 'rubocop-capybara'
   gem 'rubocop-factory_bot'
   gem 'rubocop-rails', '~> 2.29'
-  gem 'rubocop-rspec', '~> 3.3'
+  gem 'rubocop-rspec', '~> 3.4'
   gem 'rubocop-rspec_rails'
   gem 'rubocop-sequel', '~> 0.3.8'
   gem 'timecop'

Gemfile.lock

@@ -483,7 +483,7 @@ GEM
       rack (>= 1.1)
       rubocop (>= 1.52.0, < 2.0)
       rubocop-ast (>= 1.31.1, < 2.0)
-    rubocop-rspec (3.3.0)
+    rubocop-rspec (3.4.0)
       rubocop (~> 1.61)
     rubocop-rspec_rails (2.30.0)
       rubocop (~> 1.61)
@@ -657,7 +657,7 @@ DEPENDENCIES
   rubocop-capybara
   rubocop-factory_bot
   rubocop-rails (~> 2.29)
-  rubocop-rspec (~> 3.3)
+  rubocop-rspec (~> 3.4)
   rubocop-rspec_rails
   rubocop-sequel (~> 0.3.8)
   rubyzip (>= 1.3.0)