Skip to content

Commit 3e10537

Browse files
committed
Add telemetry data for usage of deployment web
Fix rollback telemetry additions
1 parent c7ba585 commit 3e10537

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

app/actions/deployment_create.rb

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ def create(app:, user_audit_info:, message:)
2525

2626
if target_state.rollback_target_revision
2727
revision = RevisionResolver.rollback_app_revision(app, target_state.rollback_target_revision, user_audit_info)
28-
log_rollback_event(app.guid, user_audit_info.user_guid, target_state.rollback_target_revision.guid, message.strategy, message.max_in_flight, message.canary_steps)
28+
log_rollback_event(app.guid, user_audit_info.user_guid, target_state.rollback_target_revision.guid, message.strategy, message.max_in_flight, message.canary_steps,
29+
message.web_instances, message.memory_in_mb, message.disk_in_mb, message.log_rate_limit_in_bytes_per_second)
2930
else
3031
revision = RevisionResolver.update_app_revision(app, user_audit_info)
3132
end
@@ -270,7 +271,7 @@ def starting_process_instances(deployment, desired_instances)
270271
[deployment.max_in_flight, starting_process_count].min
271272
end
272273

273-
def log_rollback_event(app_guid, user_id, revision_id, strategy, max_in_flight, canary_steps)
274+
def log_rollback_event(app_guid, user_id, revision_id, strategy, max_in_flight, canary_steps, instances, memory, disk, log_rate)
274275
TelemetryLogger.v3_emit(
275276
'rolled-back-app',
276277
{
@@ -282,10 +283,10 @@ def log_rollback_event(app_guid, user_id, revision_id, strategy, max_in_flight,
282283
'strategy' => strategy,
283284
'max-in-flight' => max_in_flight,
284285
'canary-steps' => canary_steps,
285-
'instances' => deployment.web_instances,
286-
'memory' => deployment.memory_in_mb,
287-
'disk' => deployment.disk_in_mb,
288-
'log-rate' => deployment.log_rate_limit_in_bytes_per_second
286+
'instances' => instances,
287+
'memory' => memory,
288+
'disk' => disk,
289+
'log-rate' => log_rate
289290
}
290291
)
291292
end

0 commit comments

Comments
 (0)