Enable CollectionQuerying

- had to use -A on rubocop to autofix

Author: moleske

.rubocop_cc.yml

@@ -271,6 +271,8 @@ Style/ArrayIntersectWithSingleElement:
   Enabled: true
 Style/BitwisePredicate:
   Enabled: true
+Style/CollectionQuerying:
+  Enabled: true
 Style/CollectionCompact:
   Enabled: true
 Style/CombinableDefined:

app/access/organization_access.rb

@@ -88,23 +88,23 @@ def validate!(org, params)
     end
 
     def validate_remove_billing_manager_by_guid!(org)
-      return if org.billing_managers_dataset.count > 1
+      return if org.billing_managers_dataset.many?
 
       raise CloudController::Errors::ApiError.new_from_details('LastBillingManagerInOrg')
     end
 
     def validate_remove_manager_by_guid!(org)
-      return if org.managers_dataset.count > 1
+      return if org.managers_dataset.many?
 
       raise CloudController::Errors::ApiError.new_from_details('LastManagerInOrg')
     end
 
     def validate_remove_user_by_guid!(org, user_guid)
-      raise CloudController::Errors::ApiError.new_from_details('LastManagerInOrg') if org.managers_dataset.count == 1 && org.managers.first.guid == user_guid
+      raise CloudController::Errors::ApiError.new_from_details('LastManagerInOrg') if org.managers_dataset.one? && org.managers.first.guid == user_guid
 
-      raise CloudController::Errors::ApiError.new_from_details('LastBillingManagerInOrg') if org.billing_managers_dataset.count == 1 && org.billing_managers.first.guid == user_guid
+      raise CloudController::Errors::ApiError.new_from_details('LastBillingManagerInOrg') if org.billing_managers_dataset.one? && org.billing_managers.first.guid == user_guid
 
-      return unless org.users_dataset.count == 1 && org.users.first.guid == user_guid && org.managers_dataset.count <= 1 && org.billing_managers_dataset.count <= 1
+      return unless org.users_dataset.one? && org.users.first.guid == user_guid && org.managers_dataset.count <= 1 && org.billing_managers_dataset.count <= 1
 
       raise CloudController::Errors::ApiError.new_from_details('LastUserInOrg')
     end

app/jobs/runtime/failed_jobs_cleanup.rb

@@ -26,7 +26,7 @@ def perform
           orphaned_delayed_jobs = Delayed::Job.
                                   where(Sequel.lit("run_at < CURRENT_TIMESTAMP - INTERVAL '?' DAY", force_delete_after))
 
-          unless orphaned_delayed_jobs.count.zero?
+          unless orphaned_delayed_jobs.none?
             logger.info("Deleting #{orphaned_delayed_jobs.count} orphaned Delayed Jobs older than #{force_delete_after} days")
 
             orphaned_delayed_jobs.delete

db/migrations/20161005205815_fix_droplets_process_types_json.rb

@@ -12,7 +12,7 @@ def add_command(command, id)
     end
 
     def flush
-      if @batched_commands.count > 0
+      if @batched_commands.any?
         cases            = []
         ids              = []
         id_place_holders = []

db/migrations/20231205143526_remove_deployments_with_degenerate.rb

@@ -2,7 +2,7 @@
   up do
     degenerate_records = self[:deployments].where(status_reason: 'DEGENERATE')
 
-    if degenerate_records.count > 0
+    if degenerate_records.any?
       guids_dataset = degenerate_records.select(:guid)
       self[:deployment_processes].where(deployment_guid: guids_dataset).delete
       self[:deployment_labels].where(resource_guid: guids_dataset).delete

lib/cloud_controller/diego/docker/staging_action_builder.rb

@@ -17,7 +17,7 @@ def action
             "-dockerRef=#{staging_details.package.image}"
           ]
 
-          if config.get(:diego, :insecure_docker_registry_list).count > 0
+          if config.get(:diego, :insecure_docker_registry_list).any?
             insecure_registries = "-insecureDockerRegistries=#{config.get(:diego, :insecure_docker_registry_list).join(',')}"
             run_args << insecure_registries
           end

lib/cloud_controller/errands/rotate_database_key.rb

@@ -32,7 +32,7 @@ def rotate_for_class(klass, batch_size)
           rows = rows_needing_rotation.
                  limit(batch_size).
                  all
-          break if rows.count == 0
+          break if rows.none?
 
           klass.instance_exec do
             @allow_manual_timestamp_update = true

lib/cloud_controller/seeds.rb

@@ -124,7 +124,7 @@ def find_routing_guid(domain)
       end
 
       def create_seed_security_groups(config)
-        return unless config.get(:security_group_definitions) && SecurityGroup.count == 0
+        return unless config.get(:security_group_definitions) && SecurityGroup.none?
 
         config.get(:security_group_definitions).each do |security_group|
           seed_security_group = security_group.dup

lib/sequel_plugins/vcap_relations.rb

@@ -6,7 +6,7 @@ def self.apply(model)
 
   module InstanceMethods
     def has_one_to_many?(association)
-      association_type(association) == :one_to_many && send(association).count > 0
+      association_type(association) == :one_to_many && send(association).any?
     end
 
     def has_one_to_one?(association)

spec/support/background_job_helpers.rb

@@ -12,7 +12,7 @@ def execute_all_jobs(expected_successes:, expected_failures:, jobs_to_execute: 1
     successes, failures = Delayed::Worker.new.work_off(jobs_to_execute)
     failure_message = "Expected #{expected_successes} successful and #{expected_failures} failed jobs, got #{successes} successful and #{failures} failed jobs."
     fail_summaries = Delayed::Job.exclude(failed_at: nil).map { |j| "Handler: #{j.handler}, LastError: #{j.last_error}" }
-    failure_message += " Failures: \n#{fail_summaries.join("\n")}" if fail_summaries.count > 0
+    failure_message += " Failures: \n#{fail_summaries.join("\n")}" if fail_summaries.any?
     expect([successes, failures]).to eq([expected_successes, expected_failures]), failure_message
 
     VCAP::CloudController::SecurityContext.set(saved_user, saved_token, saved_auth_token)