Don't schedule a delayed job for "docker" package deletion (#4103)

* there are no blobs associated with packages of type "docker", so we don't need to schedule a background job

Author: jochenehret

app/actions/package_delete.rb

@@ -8,8 +8,11 @@ def delete(packages)
       packages = Array(packages)
 
       packages.each do |package|
-        package_src_delete_job = create_package_source_deletion_job(package)
-        Jobs::Enqueuer.new(package_src_delete_job, queue: Jobs::Queues.generic).enqueue if package_src_delete_job
+        unless package.docker?
+          package_src_delete_job = create_package_source_deletion_job(package)
+          Jobs::Enqueuer.new(package_src_delete_job, queue: Jobs::Queues.generic).enqueue if package_src_delete_job
+        end
+
         package.destroy
 
         Repositories::PackageEventRepository.record_app_package_delete(

spec/unit/actions/package_delete_spec.rb

@@ -19,17 +19,28 @@ module VCAP::CloudController
           expect { package.refresh }.to raise_error Sequel::Error, 'Record not found'
         end
 
-        it 'schedules a job to the delete the blobstore item' do
-          expect do
-            package_delete.delete(package)
-          end.to change(Delayed::Job, :count).by(1)
+        context 'when the package is not of type docker' do
+          it 'schedules a job to the delete the blobstore item' do
+            expect do
+              package_delete.delete(package)
+            end.to change(Delayed::Job, :count).by(1)
+
+            job = Delayed::Job.last
+            expect(job.handler).to include('VCAP::CloudController::Jobs::Runtime::BlobstoreDelete')
+            expect(job.handler).to match(/key: ['"]?#{package.guid}/)
+            expect(job.handler).to include('package_blobstore')
+            expect(job.queue).to eq(Jobs::Queues.generic)
+            expect(job.guid).not_to be_nil
+          end
+        end
 
-          job = Delayed::Job.last
-          expect(job.handler).to include('VCAP::CloudController::Jobs::Runtime::BlobstoreDelete')
-          expect(job.handler).to match(/key: ['"]?#{package.guid}/)
-          expect(job.handler).to include('package_blobstore')
-          expect(job.queue).to eq(Jobs::Queues.generic)
-          expect(job.guid).not_to be_nil
+        context 'when the package is of type docker' do
+          it 'does not schedule a delayed job' do
+            package.type = PackageModel::DOCKER_TYPE
+            expect do
+              package_delete.delete(package)
+            end.not_to change(Delayed::Job, :count)
+          end
         end
 
         it 'creates an v3 audit event' do