App state is not updating in cf cli and appsman ui when the app is down

Code review changes

Author: nookala

lib/cloud_controller/diego/reporters/instances_stats_reporter.rb

@@ -54,10 +54,6 @@ def actual_lrp_info(process, stats=nil, quota_stats=nil, log_cache_errors=nil, i
           if lrp_instances.include?(actual_lrp.actual_lrp_key.index)
             existing_lrp = lrp_instances[actual_lrp.actual_lrp_key.index]
             next if actual_lrp.since < existing_lrp.since
-
-            lrp_instances.delete(actual_lrp.actual_lrp_key.index)
-            result.delete(actual_lrp.actual_lrp_key.index)
-            lrp_instances[actual_lrp.actual_lrp_key.index] = actual_lrp
           end
 
           lrp_state = state || LrpStateTranslator.translate_lrp_state(actual_lrp)

spec/unit/lib/cloud_controller/diego/reporters/instances_stats_reporter_spec.rb

@@ -149,7 +149,8 @@ def make_actual_lrp(instance_guid:, index:, state:, error:, since:)
         end
 
         context 'when there are multiple lrps with the same index' do
-          let(:bbs_actual_lrps_response) { [actual_lrp_1, actual_lrp_2, actual_lrp_3, actual_lrp_4] }
+          let(:desired_instances) { 3 }
+          let(:bbs_actual_lrps_response) { [actual_lrp_1, actual_lrp_2, actual_lrp_3, actual_lrp_4, actual_lrp_5] }
           let(:actual_lrp_1) do
             make_actual_lrp(
               instance_guid: '', index: 0, state: ::Diego::ActualLRPState::UNCLAIMED, error: 'some-details', since: two_days_ago_since_epoch_ns
@@ -181,14 +182,24 @@ def make_actual_lrp(instance_guid:, index:, state:, error:, since:)
             end
           end
 
+          let(:actual_lrp_5) do
+            make_actual_lrp(
+              instance_guid: 'instance-c', index: 2, state: ::Diego::ActualLRPState::RUNNING, error: 'some-details', since: two_days_ago_since_epoch_ns
+            ).tap do |actual_lrp|
+              actual_lrp.actual_lrp_net_info = lrp_1_net_info
+            end
+          end
+
           before do
             allow(bbs_instances_client).to receive_messages(lrp_instances: bbs_actual_lrps_response, desired_lrp_instance: bbs_desired_lrp_response)
           end
 
           it 'shows all correct state for all instances' do
             result, = instances_reporter.stats_for_app(process)
+            expect(result.length).to eq(3)
             expect(result[0][:state]).to eq('DOWN')
             expect(result[1][:state]).to eq('DOWN')
+            expect(result[2][:state]).to eq('RUNNING')
           end
         end