Revert "Rename user column to action_user for MySQL"

This reverts commit e7c9903.

Author: tcdowney

app/actions/process_update.rb

@@ -30,8 +30,8 @@ def update(process, message, strategy_class)
           process.skip_process_version_update = true
         end
 
-        process.command = strategy.updated_command if message.requested?(:command)
-        process.user = message.user if message.requested?(:user)
+        process.command              = strategy.updated_command if message.requested?(:command)
+        process.user                 = message.user if message.requested?(:user)
         process.health_check_timeout = message.health_check_timeout if message.requested?(:health_check_timeout)
 
         process.health_check_invocation_timeout = message.health_check_invocation_timeout if message.requested?(:health_check_invocation_timeout)

app/models/runtime/process_model.rb

@@ -174,8 +174,6 @@ def non_docker_type
 
     alias_method :diego?, :diego
 
-    alias_attribute :user, :action_user # user is a reserved column name in MySQL
-
     def revisions_enabled?
       app.revisions_enabled
     end
@@ -396,7 +394,7 @@ def started_command
     end
 
     def run_action_user
-      return action_user if action_user.present?
+      return user if user.present?
 
       docker? ? docker_run_action_user : DEFAULT_USER
     end

db/migrations/20250610212414_add_action_user_to_processes.rb

@@ -0,0 +1,13 @@
+Sequel.migration do
+  up do
+    alter_table :processes do
+      add_column :user, String, null: true, default: nil, size: 255, if_not_exists: true
+    end
+  end
+
+  down do
+    alter_table :processes do
+      drop_column :user if @db.schema(:processes).map(&:first).include?(:user)
+    end
+  end
+end

db/migrations/20250610212414_add_user_to_processes.rb

@@ -3,24 +3,24 @@
 
 RSpec.describe 'migration to add user column to processes table', isolation: :truncation, type: :migration do
   include_context 'migration' do
-    let(:migration_filename) { '20250610212414_add_action_user_to_processes.rb' }
+    let(:migration_filename) { '20250610212414_add_user_to_processes.rb' }
   end
 
   describe 'processes table' do
     it 'adds a column `user`' do
-      expect(db[:processes].columns).not_to include(:action_user)
+      expect(db[:processes].columns).not_to include(:user)
       expect { Sequel::Migrator.run(db, migrations_path, target: current_migration_index, allow_missing_migration_files: true) }.not_to raise_error
-      expect(db[:processes].columns).to include(:action_user)
+      expect(db[:processes].columns).to include(:user)
     end
 
     describe 'idempotency of up' do
       context '`user` column already exists' do
         before do
-          db.add_column :processes, :action_user, String, size: 255
+          db.add_column :processes, :user, String, size: 255
         end
 
         it 'does not fail' do
-          expect(db[:processes].columns).to include(:action_user)
+          expect(db[:processes].columns).to include(:user)
           expect { Sequel::Migrator.run(db, migrations_path, target: current_migration_index, allow_missing_migration_files: true) }.not_to raise_error
         end
       end
@@ -33,20 +33,20 @@
         end
 
         it 'continues to remove the `user_guid` column' do
-          expect(db[:processes].columns).to include(:action_user)
+          expect(db[:processes].columns).to include(:user)
           expect { Sequel::Migrator.run(db, migrations_path, target: current_migration_index - 1, allow_missing_migration_files: true) }.not_to raise_error
-          expect(db[:processes].columns).not_to include(:action_user)
+          expect(db[:processes].columns).not_to include(:user)
         end
       end
 
       context 'column does not exist' do
         before do
           Sequel::Migrator.run(db, migrations_path, target: current_migration_index, allow_missing_migration_files: true)
-          db.drop_column :processes, :action_user
+          db.drop_column :processes, :user
         end
 
         it 'does not fail' do
-          expect(db[:processes].columns).not_to include(:action_user)
+          expect(db[:processes].columns).not_to include(:user)
           expect { Sequel::Migrator.run(db, migrations_path, target: current_migration_index - 1, allow_missing_migration_files: true) }.not_to raise_error
         end
       end