Use raw sql for stack check

Author: gururajsh

lib/cloud_controller/check_stacks.rb

@@ -2,9 +2,10 @@ module VCAP::CloudController
   class CheckStacks
     attr_reader :config
 
-    def initialize(config)
+    def initialize(config, db)
       @config = config
       @stack_config = VCAP::CloudController::Stack::ConfigFile.new(config.get(:stacks_file))
+      @db = db
     end
 
     def validate_stacks
@@ -22,8 +23,10 @@ def validate_stack(deprecated_stack)
 
       return if deprecated_stack_in_config
 
-      deprecated_stack_in_db = VCAP::CloudController::Stack.first(name: deprecated_stack).present?
-
+      deprecated_stack_in_db = false
+      @db.fetch('SELECT * FROM stacks WHERE name LIKE ? ', deprecated_stack) do |_row|
+        deprecated_stack_in_db = true
+      end
       raise "rake task 'stack_check' failed, stack '#{deprecated_stack}' not supported" if deprecated_stack_in_db
     end
   end

lib/tasks/stack_check.rake

@@ -7,9 +7,7 @@ namespace :stacks do
     next unless db.table_exists?(:buildpack_lifecycle_data)
 
     RakeConfig.config.load_db_encryption_key
-    require 'models/runtime/buildpack_lifecycle_data_model'
-    require 'models/runtime/stack'
     require 'cloud_controller/check_stacks'
-    VCAP::CloudController::CheckStacks.new(RakeConfig.config).validate_stacks
+    VCAP::CloudController::CheckStacks.new(RakeConfig.config, db).validate_stacks
   end
 end

spec/tasks/stack_check_spec.rb

@@ -52,6 +52,7 @@
       before do
         allow(db_double).to receive(:table_exists?).with(:stacks).and_return true
         allow(VCAP::CloudController::DB).to receive(:connect).and_return(db_double)
+        allow(db_double).to receive(:fetch).with('SELECT * FROM stacks WHERE name LIKE ? ', 'cflinuxfs3').and_return('1')
       end
 
       it 'validates stacks' do
@@ -78,6 +79,7 @@
       before do
         allow(double).to receive(:table_exists?).with(:buildpack_lifecycle_data).and_return true
         allow(VCAP::CloudController::DB).to receive(:connect).and_return(db_double)
+        allow(db_double).to receive(:fetch).with('SELECT * FROM stacks WHERE name LIKE ? ', 'cflinuxfs3').and_return('1')
       end
 
       it 'validates stacks' do

spec/unit/lib/cloud_controller/check_stacks_spec.rb

@@ -28,7 +28,7 @@ module VCAP::CloudController
       TestConfig.override(stacks_file: file.path)
     end
 
-    let(:stack_checker) { CheckStacks.new(TestConfig.config_instance) }
+    let(:stack_checker) { CheckStacks.new(TestConfig.config_instance, DbConfig.new.connection) }
 
     describe 'the deprecated stacks is nil' do
       let(:stack_file_contents) do