Add "icmpv6" protocol to SecurityGroup class

Author: jochenehret

app/models/runtime/security_group.rb

@@ -71,7 +71,7 @@ def validate_rules
         validation_errors = case protocol
                             when 'tcp', 'udp'
                               CloudController::TransportRuleValidator.validate(stringified_rule)
-                            when 'icmp'
+                            when 'icmp', 'icmpv6'
                               CloudController::ICMPRuleValidator.validate(stringified_rule)
                             when 'all'
                               CloudController::RuleValidator.validate(stringified_rule)

spec/unit/models/runtime/security_group_spec.rb

@@ -19,6 +19,15 @@ def build_icmp_rule(attrs={})
       }.merge(attrs)
     end
 
+    def build_icmpv6_rule(attrs={})
+      {
+        'protocol' => 'icmpv6',
+        'type' => 0,
+        'code' => 0,
+        'destination' => '::/0'
+      }.merge(attrs)
+    end
+
     def build_all_rule(attrs={})
       {
         'protocol' => 'all',
@@ -601,13 +610,37 @@ def build_all_rule(attrs={})
                   end
                 end
 
+                context 'when it is a valid IPv6 CIDR' do
+                  before do
+                    TestConfig.config[:enable_ipv6] = true
+                  end
+
+                  let(:rule) { build_icmpv6_rule('destination' => '2001:db8::/32') }
+
+                  it 'is valid' do
+                    expect(subject).to be_valid
+                  end
+                end
+
                 context 'when it is a valid range' do
                   let(:rule) { build_icmp_rule('destination' => '1.1.1.1-2.2.2.2') }
 
                   it 'is valid' do
                     expect(subject).to be_valid
                   end
                 end
+
+                context 'when it is a valid IPv6 range' do
+                  before do
+                    TestConfig.config[:enable_ipv6] = true
+                  end
+
+                  let(:rule) { build_icmpv6_rule('destination' => '2001:0db8::1-2001:0db8::ff') }
+
+                  it 'is valid' do
+                    expect(subject).to be_valid
+                  end
+                end
               end
 
               context 'bad' do