fix: transient attribute username sent as argument. (#4552)

During queuing of RoleDeletAction, the role_owner object is serialized.
In such cases transient attributes such as username will be lost.

Author: serdarozerr

app/actions/role_delete.rb

@@ -5,12 +5,14 @@ class RoleDeleteAction
     class RoleDeleteError < StandardError
     end
 
-    def initialize(user_audit_info, role_owner)
+    def initialize(user_audit_info, role_owner, role_owner_username)
       @user_audit_info = user_audit_info
       @role_owner = role_owner
+      @role_owner_username = role_owner_username
     end
 
     def delete(roles)
+      @role_owner.username = @role_owner_username if @role_owner_username.present?
       roles.each do |role|
         Role.db.transaction do
           record_event(role)

app/controllers/v3/roles_controller.rb

@@ -84,7 +84,8 @@ def destroy
     end
 
     role_owner = fetch_role_owner_with_name(role)
-    delete_action = RoleDeleteAction.new(user_audit_info, role_owner)
+    # Pass username separately to preserve transient attribute through delayed job serialization
+    delete_action = RoleDeleteAction.new(user_audit_info, role_owner, role_owner.username)
     deletion_job = VCAP::CloudController::Jobs::DeleteActionJob.new(Role, role.guid, delete_action)
     pollable_job = Jobs::Enqueuer.new(queue: Jobs::Queues.generic).enqueue_pollable(deletion_job)
 

spec/unit/actions/role_delete_spec.rb

@@ -12,7 +12,7 @@ module VCAP::CloudController
       allow(user_with_role).to receive(:username).and_return('kiwi')
     end
 
-    subject { RoleDeleteAction.new(user_audit_info, user_with_role) }
+    subject { RoleDeleteAction.new(user_audit_info, user_with_role, user_with_role.username) }
 
     describe '#delete' do
       shared_examples 'deletion' do |opts|