Revert "Catch error thrown if Diego Process Sync creates a desired lrp process"

Revert "Remove unnecessary logger"
Revert "Rubocop fixes"

This reverts commits:
e321fa8.
fc96bb6.
133486e.

Author: Gerg

lib/cloud_controller/diego/desire_app_handler.rb

@@ -6,16 +6,7 @@ def create_or_update_app(process, client)
           if (existing_lrp = client.get_app(process))
             client.update_app(process, existing_lrp)
           else
-            begin
-              client.desire_app(process)
-            rescue CloudController::Errors::ApiError => e # catch race condition if Diego Process Sync creates an LRP in the meantime
-              if e.name == 'RunnerError' && e.message['the requested resource already exists']
-                existing_lrp = client.get_app(process)
-                client.update_app(process, existing_lrp)
-              elsif e.name == 'UnprocessableEntity'
-                raise
-              end
-            end
+            client.desire_app(process)
           end
         end
       end

spec/unit/lib/cloud_controller/diego/desire_app_handler_spec.rb

@@ -35,34 +35,6 @@ module Diego
             expect(client).not_to have_received(:desire_app)
           end
         end
-
-        context 'race condition when the Diego::ProcessesSync runs and creates a process ahead of the DesireAppHandler' do
-          let(:desired_lrp_update) { double(:desired_lrp_update) }
-          let(:get_app_response) { nil }
-
-          before do
-            allow(client).to receive(:update_app)
-            allow(client).to receive(:desire_app).and_raise CloudController::Errors::ApiError.new_from_details('RunnerError', 'the requested resource already exists')
-          end
-
-          it 'catches the error and updates the app' do
-            DesireAppHandler.create_or_update_app(process, client)
-            expect(client).to have_received(:update_app)
-            expect(client).to have_received(:get_app).exactly(2).times
-          end
-        end
-
-        context 'when root user is not permitted' do
-          it 'raises a CloudController::Errors::ApiError' do
-            allow(client).to receive(:desire_app).and_raise(CloudController::Errors::ApiError.new_from_details('UnprocessableEntity',
-                                                                                                               'Attempting to run process as root user, which is not permitted.'))
-            expect { DesireAppHandler.create_or_update_app(process, client) }.to(raise_error do |error|
-              expect(error).to be_a(CloudController::Errors::ApiError)
-              expect(error.name).to eq('UnprocessableEntity')
-              expect(error.message).to include('Attempting to run process as root user, which is not permitted')
-            end)
-          end
-        end
       end
     end
   end