Remove unnecessary route.reload after updating destinations

philippthun · philippthun · commit 83cc761e1f3c · 2026-03-20T12:00:08.000+01:00
The reload and return value were unused by all callers. Removing them
fixes a race condition where concurrent route deletion caused 500 errors.

Observed error:
Record not found (Sequel::NoExistingObject) at
update_route_destinations.rb:97 in reload
diff --git a/app/actions/update_route_destinations.rb b/app/actions/update_route_destinations.rb
@@ -93,10 +93,6 @@ def update(route, to_add, to_delete, user_audit_info, manifest_triggered)
 
           update_processes(processes_to_ports_map)
         end
-
-        route.reload
-
-        route
       end
 
       def update_processes(processes_to_ports_map)
