Can't push apps with app manifests if routes were shared

Check if route shared with space and don't throw error if shared

Author: nookala

app/actions/manifest_route_update.rb

@@ -90,8 +90,12 @@ def find_or_create_valid_route(app, manifest_route, user_audit_info)
               domain: existing_domain,
               manifest_triggered: true
             )
-          elsif route.space.guid != app.space_guid
-            raise InvalidRoute.new('Routes cannot be mapped to destinations in different spaces')
+          elsif route.space.guid != app.space_guid  
+            # check if route is shared with space
+            spaces = route.shared_spaces
+            if (spaces.blank?) || (!spaces.any? { |space| space.values[:id] == app.space.id })
+              raise InvalidRoute.new('Routes cannot be mapped to destinations in different spaces')
+            end
           end
 
           return route

spec/unit/actions/manifest_route_update_spec.rb

@@ -121,6 +121,18 @@ module VCAP::CloudController
                                  'Routes cannot be mapped to destinations in different spaces')
             end
           end
+
+          context 'when the route is shared' do
+            let!(:route_share) { RouteShare.new }
+            let!(:outside_app) { AppModel.make }
+            let!(:shared_route) { route_share.create(route, [outside_app.space], user_audit_info) }
+
+             it 'succeeds after route share' do
+              expect do
+                ManifestRouteUpdate.update(outside_app.guid, message, user_audit_info)
+              end.not_to raise_error
+            end
+          end
         end
       end