Skip to content

Commit 8c597d7

Browse files
committed
remove PUT fir v3/service_instances|service-bindings from rate limit because PUT in v3 is not present
1 parent 86ce2a0 commit 8c597d7

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

middleware/service_broker_rate_limiter.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ module Middleware
77

88
RATE_LIMITED_ENDPOINTS = [
99
RateLimitEndpoint.new(%r{\A/v2/(service_instances|service_credential_bindings|service_route_bindings)}, %w[PUT POST DELETE PATCH]),
10-
RateLimitEndpoint.new(%r{\A/v3/(service_instances|service_credential_bindings|service_route_bindings)/.+/parameters\z}, %w[GET]),
11-
RateLimitEndpoint.new(%r{\A/v3/(service_instances|service_credential_bindings|service_route_bindings)}, %w[PUT])
10+
RateLimitEndpoint.new(%r{\A/v3/(service_instances|service_credential_bindings|service_route_bindings)/.+/parameters\z}, %w[GET])
1211
].freeze
1312

1413
class ConcurrentRequestCounter

spec/unit/middleware/service_broker_rate_limiter_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ module Middleware
2525
end
2626

2727
describe 'included requests' do
28-
let(:fake_request) { instance_double(ActionDispatch::Request, fullpath: '/v3/service_instances', method: 'PUT') }
28+
let(:fake_request) { instance_double(ActionDispatch::Request, fullpath: '/v2/service_instances', method: 'PUT') }
2929

3030
it 'allows a service broker request within the limit' do
3131
status, = middleware.call(user_env)
@@ -120,7 +120,7 @@ module Middleware
120120
end
121121

122122
describe 'excluded requests' do
123-
let(:request_method) { 'POST' }
123+
let(:fake_request) { instance_double(ActionDispatch::Request, fullpath: '/v3/service_instances', method: 'POST') }
124124

125125
it 'allows requests that are no longer rate limited' do
126126
status, = middleware.call(user_env)

0 commit comments

Comments
 (0)