Turn off publishing metrics by default and make configurable

Author: svkrieger

lib/cloud_controller/config_schemas/base/worker_schema.rb

@@ -143,6 +143,9 @@ class WorkerSchema < VCAP::Config
               optional(:port) => Integer
             },
 
+            optional(:publish_metrics) => bool,
+            optional(:prometheus_port) => Integer,
+
             skip_cert_verify: bool,
 
             optional(:routing_api) => {

lib/delayed_job/delayed_worker.rb

@@ -22,7 +22,7 @@ def initialize(options)
 
   def start_working
     config = RakeConfig.config
-    setup_metrics_endpoint if @publish_metrics
+    setup_metrics_endpoint(config) if @publish_metrics
     BackgroundJobEnvironment.new(config).setup_environment(readiness_port)
 
     logger = Steno.logger('cc-worker')
@@ -99,8 +99,8 @@ def is_first_generic_worker_on_machine?
     RakeConfig.context != :api && ENV['INDEX']&.to_i == 1
   end
 
-  def setup_metrics_endpoint
-    prometheus_dir = File.join(RakeConfig.config.get(:directories, :tmpdir), 'prometheus')
+  def setup_metrics_endpoint(config)
+    prometheus_dir = File.join(config.get(:directories, :tmpdir), 'prometheus')
     Prometheus::Client.config.data_store = Prometheus::Client::DataStores::DirectFileStore.new(dir: prometheus_dir)
     return unless is_first_generic_worker_on_machine?
 
@@ -124,7 +124,7 @@ def setup_metrics_endpoint
 
     Thread.new do
       server = Puma::Server.new(metrics_app)
-      server.add_tcp_listener '0.0.0.0', 9394
+      server.add_tcp_listener '0.0.0.0', config.get(:prometheus_port) || 9394
       server.run
     end
   end

lib/tasks/jobs.rake

@@ -66,10 +66,12 @@ namespace :jobs do
 
     ENV['PROCESS_TYPE'] = 'cc-worker'
 
+    publish_metrics = RakeConfig.config.get(:publish_metrics) || false
+
     CloudController::DelayedWorker.new(queues: queues,
                                        name: args.name,
                                        num_threads: args.num_threads,
                                        thread_grace_period_seconds: args.thread_grace_period_seconds,
-                                       publish_metrics: true).start_working
+                                       publish_metrics: publish_metrics).start_working
   end
 end