Add validation for options/lb_algo

Author: hoffmaen

app/controllers/v3/routes_controller.rb

@@ -78,7 +78,6 @@ def create
 
     space = Space.find(guid: message.space_guid)
     domain = Domain.find(guid: message.domain_guid)
-    options = message.
 
     unprocessable_space! unless space
     unprocessable_domain! unless domain

app/messages/route_create_message.rb

@@ -57,6 +57,7 @@ class RouteCreateMessage < MetadataBaseMessage
 
     validates_with NoAdditionalKeysValidator
     validates_with RelationshipValidator
+    validates_with OptionsValidator
 
     delegate :space_guid, to: :relationships_message
     delegate :domain_guid, to: :relationships_message
@@ -66,6 +67,10 @@ def relationships_message
       @relationships_message ||= Relationships.new(relationships&.deep_symbolize_keys)
     end
 
+    def options_message
+      @options_message ||= RouteOptions.new(options&.deep_symbolize_keys)
+    end
+
     def wildcard?
       host == '*'
     end
@@ -86,11 +91,13 @@ def domain_guid
       end
     end
 
-    # class RouteOptions < BaseMessage
-    #   register_allowed_keys %i[loadbalancing-algorithm]
-    #   validates_with NoAdditionalKeysValidator
-    #   validates :loadbalancing-algorithm, to_one_relationship: true
-    # end
-
+    class RouteOptions < BaseMessage
+      register_allowed_keys %i[lb_algo]
+      validates_with NoAdditionalKeysValidator
+      validates :lb_algo,
+                inclusion: { in: %w[least-connections round-robin], message: 'must be \'least-connections\' or \'round-robin\'' },
+                presence: true,
+                allow_nil: true
+    end
   end
 end

app/messages/validators.rb

@@ -240,6 +240,28 @@ def validate(record)
     end
   end
 
+  class OptionsValidator < ActiveModel::Validator
+    def validate(record)
+      unless record.options.is_a?(Hash)
+        record.errors.add(:options, message: "'options' is not an object")
+        return
+      end
+
+      if record.options.empty?
+        record.errors.add(:options, message: "'options' must include one or more valid options")
+        return
+      end
+
+      opt = record.options_message
+
+      return if opt.valid?
+
+      opt.errors.full_messages.each do |message|
+        record.errors.add(:options, message:)
+      end
+    end
+  end
+
   class ToOneRelationshipValidator < ActiveModel::EachValidator
     def validate_each(record, attribute, relationship)
       if has_correct_structure?(relationship)