Use raw sql for stack check (#4106)

* Use raw sql for stack check

* Move config file class out of stack

* Rename file

* Rename config references

* Use raw sql for stack check

* Rubocop changes

* Remove not needed checks

* Use empty check

* Use empty check

Author: gururajsh

app/models/helpers/stack_config_file.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module VCAP::CloudController
+  class StackConfigFile
+    def initialize(file_path)
+      @hash = YAMLConfig.safe_load_file(file_path).tap do |h|
+        Schema.validate(h)
+      end
+    end
+
+    def stacks
+      @hash['stacks']
+    end
+
+    def deprecated_stacks
+      @hash['deprecated_stacks']
+    end
+
+    def default
+      @hash['default']
+    end
+
+    Schema = Membrane::SchemaParser.parse do
+      {
+        'default' => String,
+        'stacks' => [{
+          'name' => String,
+          'description' => String,
+          optional('build_rootfs_image') => String,
+          optional('run_rootfs_image') => String
+        }],
+        optional('deprecated_stacks') => [
+          String
+        ]
+      }
+    end
+  end
+end

app/models/runtime/stack.rb

@@ -1,4 +1,5 @@
 require 'models/helpers/process_types'
+require 'models/helpers/stack_config_file'
 
 module VCAP::CloudController
   class Stack < Sequel::Model
@@ -65,7 +66,7 @@ def run_rootfs_image
     end
 
     def self.configure(file_path)
-      @config_file = (ConfigFile.new(file_path) if file_path)
+      @config_file = (StackConfigFile.new(file_path) if file_path)
     end
 
     def self.populate
@@ -97,40 +98,5 @@ def self.populate_from_hash(hash)
         create(hash.slice('name', 'description', 'build_rootfs_image', 'run_rootfs_image'))
       end
     end
-
-    class ConfigFile
-      def initialize(file_path)
-        @hash = YAMLConfig.safe_load_file(file_path).tap do |h|
-          Schema.validate(h)
-        end
-      end
-
-      def stacks
-        @hash['stacks']
-      end
-
-      def deprecated_stacks
-        @hash['deprecated_stacks']
-      end
-
-      def default
-        @hash['default']
-      end
-
-      Schema = Membrane::SchemaParser.parse do
-        {
-          'default' => String,
-          'stacks' => [{
-            'name' => String,
-            'description' => String,
-            optional('build_rootfs_image') => String,
-            optional('run_rootfs_image') => String
-          }],
-          optional('deprecated_stacks') => [
-            String
-          ]
-        }
-      end
-    end
   end
 end

lib/cloud_controller/check_stacks.rb

@@ -2,9 +2,10 @@ module VCAP::CloudController
   class CheckStacks
     attr_reader :config
 
-    def initialize(config)
+    def initialize(config, db)
       @config = config
-      @stack_config = VCAP::CloudController::Stack::ConfigFile.new(config.get(:stacks_file))
+      @stack_config = VCAP::CloudController::StackConfigFile.new(config.get(:stacks_file))
+      @db = db
     end
 
     def validate_stacks
@@ -19,12 +20,11 @@ def validate_stacks
     def validate_stack(deprecated_stack)
       configured_stacks = @stack_config.stacks
       deprecated_stack_in_config = (configured_stacks.find { |stack| stack['name'] == deprecated_stack }).present?
-
       return if deprecated_stack_in_config
 
-      deprecated_stack_in_db = VCAP::CloudController::Stack.first(name: deprecated_stack).present?
+      no_deprecated_stack_in_db = @db.fetch('SELECT 1 FROM stacks WHERE name LIKE ? ', deprecated_stack).empty?
 
-      raise "rake task 'stack_check' failed, stack '#{deprecated_stack}' not supported" if deprecated_stack_in_db
+      raise "rake task 'stack_check' failed, stack '#{deprecated_stack}' not supported" unless no_deprecated_stack_in_db
     end
   end
 end

lib/tasks/stack_check.rake

@@ -4,12 +4,9 @@ namespace :stacks do
     logger = Steno.logger('cc.stack')
     db = VCAP::CloudController::DB.connect(RakeConfig.config.get(:db), logger)
     next unless db.table_exists?(:stacks)
-    next unless db.table_exists?(:buildpack_lifecycle_data)
 
-    RakeConfig.config.load_db_encryption_key
-    require 'models/runtime/buildpack_lifecycle_data_model'
-    require 'models/runtime/stack'
+    require 'models/helpers/stack_config_file'
     require 'cloud_controller/check_stacks'
-    VCAP::CloudController::CheckStacks.new(RakeConfig.config).validate_stacks
+    VCAP::CloudController::CheckStacks.new(RakeConfig.config, db).validate_stacks
   end
 end

spec/tasks/stack_check_spec.rb

@@ -55,33 +55,7 @@
       end
 
       it 'validates stacks' do
-        expect_any_instance_of(VCAP::CloudController::CheckStacks).to receive(:validate_stacks).and_call_original
-        Rake::Task['stacks:stack_check'].execute
-      end
-    end
-  end
-
-  context 'buildpack_lifecycle_data' do
-    context 'when buildpack_lifecycle_data table doesnt exist' do
-      before do
-        allow(db_double).to receive(:table_exists?).with(:buildpack_lifecycle_data).and_return false
-        allow(VCAP::CloudController::DB).to receive(:connect).and_return(db_double)
-      end
-
-      it 'does nothing' do
-        expect_any_instance_of(VCAP::CloudController::CheckStacks).not_to receive(:validate_stacks)
-        Rake::Task['stacks:stack_check'].execute
-      end
-    end
-
-    context 'when buildpack_lifecycle_data table does exist' do
-      before do
-        allow(double).to receive(:table_exists?).with(:buildpack_lifecycle_data).and_return true
-        allow(VCAP::CloudController::DB).to receive(:connect).and_return(db_double)
-      end
-
-      it 'validates stacks' do
-        expect_any_instance_of(VCAP::CloudController::CheckStacks).to receive(:validate_stacks).and_call_original
+        expect_any_instance_of(VCAP::CloudController::CheckStacks).to receive(:validate_stacks)
         Rake::Task['stacks:stack_check'].execute
       end
     end

spec/unit/lib/cloud_controller/check_stacks_spec.rb

@@ -28,7 +28,7 @@ module VCAP::CloudController
       TestConfig.override(stacks_file: file.path)
     end
 
-    let(:stack_checker) { CheckStacks.new(TestConfig.config_instance) }
+    let(:stack_checker) { CheckStacks.new(TestConfig.config_instance, DbConfig.new.connection) }
 
     describe 'the deprecated stacks is nil' do
       let(:stack_file_contents) do