new try

Author: johha

lib/cloud_controller/blobstore/storage_cli/storage_cli_client.rb

@@ -13,18 +13,20 @@ class StorageCliClient < BaseClient
       @registry = {}
 
       class << self
+        attr_reader :registry
+
         def register(provider, klass)
-          @registry[provider] = klass
+          registry[provider] = klass
         end
 
         def build(connection_config:, directory_key:, root_dir:, min_size: nil, max_size: nil)
           provider = connection_config[:provider]
           raise 'Missing connection_config[:provider]' if provider.nil?
 
-          impl_class = @registry[provider]
+          impl_class = registry[provider]
           raise "No storage CLI client registered for provider #{provider}" unless impl_class
 
-          impl_class.new(connection_config:, directory_key:, root_dir:, min_size:, max_size:, fork:)
+          impl_class.new(connection_config:, directory_key:, root_dir:, min_size:, max_size:)
         end
       end
 

spec/unit/lib/cloud_controller/blobstore/storage_cli/storage_cli_client_spec.rb

@@ -1,19 +1,13 @@
 require 'spec_helper'
-require_relative '../client_shared'
+require 'cloud_controller/blobstore/storage_cli/azure_storage_cli_client'
 
 module CloudController
   module Blobstore
     RSpec.describe StorageCliClient do
       describe 'registry build and lookup' do
-        class DummyClient < StorageCliClient
-          def initialize(*); end
-        end
-
-        before { StorageCliClient.register('DummyProvider', DummyClient) }
-
         it 'builds the correct client' do
-          client_from_registry = StorageCliClient.build(connection_config: { provider: 'DummyProvider' }, directory_key: 'dummy-key', root_dir: 'dummy-root')
-          expect(client_from_registry).to be_a(DummyClient)
+          client_from_registry = StorageCliClient.build(connection_config: { provider: 'AzureRM' }, directory_key: 'dummy-key', root_dir: 'dummy-root')
+          expect(client_from_registry).to be_a(AzureStorageCliClient)
         end
 
         it 'raises an error for an unregistered provider' do