Add lifecycle column to the buildpacks table

Co-authored-by: Pavel Busko <[email protected]>

Author: 2 people

app/actions/buildpack_create.rb

@@ -14,6 +14,7 @@ def create(message)
         buildpack = Buildpack.create(
           name: message.name,
           stack: message.stack,
+          lifecycle: (message.lifecycle.nil? ? VCAP::CloudController::Config.config.get(:default_app_lifecycle) : message.lifecycle),
           enabled: (message.enabled.nil? ? DEFAULT_ENABLED : message.enabled),
           locked: (message.locked.nil? ? DEFAULT_LOCKED : message.locked)
         )

app/messages/buildpack_create_message.rb

@@ -1,12 +1,13 @@
 require 'messages/metadata_base_message'
 require 'messages/validators'
+require 'cloud_controller/diego/lifecycles/lifecycles'
 
 module VCAP::CloudController
   class BuildpackCreateMessage < MetadataBaseMessage
     MAX_BUILDPACK_NAME_LENGTH = 250
     MAX_STACK_LENGTH = 250
 
-    register_allowed_keys %i[name stack position enabled locked]
+    register_allowed_keys %i[name stack position enabled locked lifecycle]
     validates_with NoAdditionalKeysValidator
 
     validates :name,
@@ -32,5 +33,10 @@ class BuildpackCreateMessage < MetadataBaseMessage
     validates :locked,
               allow_nil: true,
               boolean: true
+
+    validates :lifecycle,
+              string: true,
+              allow_nil: true,
+              inclusion: { in: [VCAP::CloudController::Lifecycles::BUILDPACK, VCAP::CloudController::Lifecycles::CNB], message: 'must be either "buildpack" or "cnb"' }
   end
 end

app/presenters/v3/buildpack_presenter.rb

@@ -13,6 +13,7 @@ def to_hash
         name: buildpack.name,
         stack: buildpack.stack,
         state: buildpack.state,
+        lifecycle: buildpack.lifecycle,
         filename: buildpack.filename,
         position: buildpack.position,
         enabled: buildpack.enabled,

db/migrations/20240710152700_cnb_system_buildpacks.rb

@@ -0,0 +1,11 @@
+require 'cloud_controller/diego/lifecycles/lifecycles'
+
+Sequel.migration do
+  up do
+    add_column :buildpacks, :lifecycle, String, size: 16, if_not_exists: true, default: VCAP::CloudController::Lifecycles::BUILDPACK
+  end
+
+  down do
+    drop_column :buildpacks, :lifecycle, if_exists: true
+  end
+end