Fix ignored unique constraint error name

Also add tests to ensure that `ignored_unique_constraint_violation_errors` is set correctly.

Author: johha

app/models/runtime/security_group.rb

@@ -12,7 +12,7 @@ class SecurityGroup < Sequel::Model
 
     serialize_attributes :json, :rules
 
-    many_to_many :spaces, ignored_unique_constraint_violation_errors: %w[ignored_unique_constraint_violation_errors]
+    many_to_many :spaces, ignored_unique_constraint_violation_errors: %w[security_groups_spaces_ids]
     many_to_many :staging_spaces,
                  class: 'VCAP::CloudController::Space',
                  join_table: 'staging_security_groups_spaces',

spec/unit/models/runtime/domain_spec.rb

@@ -36,6 +36,12 @@ module VCAP::CloudController
           expect(domain.shared_organizations).to include(org)
         end
 
+        it 'ignores unique constraint violation errors in the many_to_many relationship definition' do
+          index_name = :orgs_pd_ids
+          expect(DbConfig.new.connection.indexes(:organizations_private_domains)).to include(index_name)
+          expect(Domain.association_reflection(:shared_organizations)[:ignored_unique_constraint_violation_errors]).to include(index_name.to_s)
+        end
+
         context 'when the domain is a shared domain' do
           it 'fails validation' do
             domain = Domain.make(owning_organization_id: nil)

spec/unit/models/runtime/route_spec.rb

@@ -113,6 +113,11 @@ module VCAP::CloudController
       it { is_expected.to have_associated :space, associated_instance: ->(route) { Space.make(organization: route.domain.owning_organization) } }
       it { is_expected.to have_associated :route_mappings, associated_instance: ->(route) { RouteMappingModel.make(app: AppModel.make(space: route.space), route: route) } }
 
+      it 'ignores unique constraint violation errors in the many_to_many relationship definition' do
+        index_name = DbConfig.new.connection.adapter_scheme == :postgres ? :route_target_space_pk : :'route_shares.PRIMARY'
+        expect(Route.association_reflection(:shared_spaces)[:ignored_unique_constraint_violation_errors]).to include(index_name.to_s)
+      end
+
       describe 'apps association' do
         let(:space) { Space.make }
         let(:process) { ProcessModelFactory.make(space:) }

spec/unit/models/runtime/security_group_spec.rb

@@ -421,6 +421,12 @@ def build_all_rule(attrs={})
 
           expect { security_group.destroy }.not_to raise_error
         end
+
+        it 'ignores unique constraint violation errors in the many_to_many relationship definition' do
+          index_name = :security_groups_spaces_ids
+          expect(DbConfig.new.connection.indexes(:security_groups_spaces)).to include(index_name)
+          expect(SecurityGroup.association_reflection(:spaces)[:ignored_unique_constraint_violation_errors]).to include(index_name.to_s)
+        end
       end
 
       describe 'staging_spaces' do
@@ -432,6 +438,12 @@ def build_all_rule(attrs={})
 
           expect { security_group.destroy }.not_to raise_error
         end
+
+        it 'ignores unique constraint violation errors in the many_to_many relationship definition' do
+          index_name = :staging_security_groups_spaces_ids
+          expect(DbConfig.new.connection.indexes(:staging_security_groups_spaces)).to include(index_name)
+          expect(SecurityGroup.association_reflection(:staging_spaces)[:ignored_unique_constraint_violation_errors]).to include(index_name.to_s)
+        end
       end
     end
 

spec/unit/models/services/service_instance_spec.rb

@@ -149,6 +149,11 @@ module VCAP::CloudController
               UserProvidedServiceInstance.make(name: 'shared-service', space: space)
             end.to raise_error(Sequel::ValidationFailed, /name unique/)
           end
+
+          it 'ignores unique constraint violation errors in the many_to_many relationship definition' do
+            index_name = DbConfig.new.connection.adapter_scheme == :postgres ? :service_instance_target_space_pk : :'service_instance_shares.PRIMARY'
+            expect(ManagedServiceInstance.association_reflection(:shared_spaces)[:ignored_unique_constraint_violation_errors]).to include(index_name.to_s)
+          end
         end
       end
     end