Stack Management - Model update and Unit Test

Signed-off-by: Rashed Kamal <[email protected]>

Author: rashedkvm

app/models/runtime/stack.rb

@@ -10,6 +10,18 @@ class MissingDefaultStackError < StandardError
     class AppsStillPresentError < StandardError
     end
 
+    STACK_ACTIVE = 'ACTIVE'.freeze
+    STACK_RESTRICTED = 'RESTRICTED'.freeze
+    STACK_DEPRECATED = 'DEPRECATED'.freeze
+    STACK_DISABLED = 'DISABLED'.freeze
+
+    VALID_STATES = [
+      STACK_ACTIVE,
+      STACK_RESTRICTED,
+      STACK_DEPRECATED,
+      STACK_DISABLED
+    ].freeze
+
     # NOTE: that "apps" here returns processes for v2 meta-reasons
     many_to_many :apps,
                  class: 'VCAP::CloudController::ProcessModel',
@@ -43,6 +55,7 @@ def around_save
     def validate
       validates_presence :name
       validates_unique :name
+      validates_includes VALID_STATES, :state, allow_nil: true
     end
 
     def before_destroy
@@ -98,5 +111,28 @@ def self.populate_from_hash(hash)
         create(hash.slice('name', 'description', 'build_rootfs_image', 'run_rootfs_image'))
       end
     end
+    def active?
+      state == STACK_ACTIVE
+    end
+
+    def deprecated?
+      state == STACK_DEPRECATED
+    end
+
+    def restricted?
+      state == STACK_RESTRICTED
+    end
+
+    def disabled?
+      state == STACK_DISABLED
+    end
+
+    def can_stage_new_app?
+      !restricted? && !disabled?
+    end
+
+    def can_restage_apps?
+      !disabled?
+    end
   end
 end

spec/unit/models/runtime/stack_spec.rb

@@ -26,11 +26,34 @@ module VCAP::CloudController
       it { is_expected.to validate_presence :name }
       it { is_expected.to validate_uniqueness :name }
       it { is_expected.to strip_whitespace :name }
+
+      describe 'state validation' do
+        it 'accepts valid states' do
+          stack = Stack.make
+          Stack::VALID_STATES.each do |valid_state|
+            stack.state = valid_state
+            expect(stack).to be_valid
+          end
+        end
+
+        it 'rejects invalid states' do
+          stack = Stack.make
+          stack.state = 'INVALID'
+          expect(stack).not_to be_valid
+          expect(stack.errors[:state]).to include(:includes)
+        end
+
+        it 'allows nil state' do
+          stack = Stack.make
+          stack.state = nil
+          expect(stack).to be_valid
+        end
+      end
     end
 
     describe 'Serialization' do
       it { is_expected.to export_attributes :name, :description, :build_rootfs_image, :run_rootfs_image }
-      it { is_expected.to import_attributes :name, :description, :build_rootfs_image, :run_rootfs_image }
+      it { is_expected.to import_attributes :name, :description, :build_rootfs_image, :run_rootfs_image}
     end
 
     describe '.configure' do