Skip to content

Commit abb4a1f

Browse files
committed
adapt tests
1 parent d4ca4ba commit abb4a1f

File tree

2 files changed

+39
-4
lines changed

2 files changed

+39
-4
lines changed

spec/unit/lib/cloud_controller/blobstore/storage_cli/azure_storage_cli_client_spec.rb

Lines changed: 35 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,46 @@
11
require 'spec_helper'
2+
require 'tempfile'
3+
require 'json'
24
require_relative '../client_shared'
35
require 'cloud_controller/blobstore/storage_cli/azure_storage_cli_client'
46
require 'cloud_controller/blobstore/storage_cli/storage_cli_blob'
57

68
module CloudController
79
module Blobstore
810
RSpec.describe AzureStorageCliClient do
9-
subject(:client) { AzureStorageCliClient.new(connection_config: connection_config, directory_key: directory_key, root_dir: 'bommel') }
11+
let!(:tmp_cfg) do
12+
f = Tempfile.new(['storage_cli_config', '.json'])
13+
f.write({ provider: 'AzureRM',
14+
account_name: 'some-account-name',
15+
account_key: 'some-access-key',
16+
container_name: directory_key,
17+
environment: 'AzureCloud' }.to_json)
18+
f.flush
19+
f
20+
end
21+
22+
before do
23+
cc_cfg = instance_double('VCAP::CloudController::Config')
24+
allow(VCAP::CloudController::Config).to receive(:config).and_return(cc_cfg)
25+
26+
allow(cc_cfg).to receive(:get) do |key, *_|
27+
case key
28+
when :storage_cli_config_file_droplets,
29+
:storage_cli_config_file_buildpacks,
30+
:storage_cli_config_file_packages,
31+
:storage_cli_config_file_resource_pool
32+
tmp_cfg.path
33+
else
34+
nil
35+
end
36+
end
37+
end
38+
39+
after { tmp_cfg.close! }
40+
41+
subject(:client) { AzureStorageCliClient.new(connection_config: connection_config, directory_key: directory_key, resource_type: resource_type, root_dir: 'bommel') }
1042
let(:directory_key) { 'my-bucket' }
43+
let(:resource_type) { 'resource_pool' }
1144
let(:connection_config) do
1245
{
1346
azure_storage_access_key: 'some-access-key',
@@ -59,7 +92,7 @@ module Blobstore
5992
expect(client.instance_variable_get(:@config_file)).to be_a(String)
6093
expect(File.exist?(client.instance_variable_get(:@config_file))).to be true
6194
expect(File.read(client.instance_variable_get(:@config_file))).to eq(
62-
'{"account_name":"some-account-name","account_key":"some-access-key","container_name":"my-bucket","environment":"AzureCloud"}'
95+
'{"provider":"AzureRM","account_name":"some-account-name","account_key":"some-access-key","container_name":"my-bucket","environment":"AzureCloud"}'
6396
)
6497
end
6598
end

spec/unit/lib/cloud_controller/dependency_locator_spec.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@
7777
it 'creates blob store' do
7878
expect(CloudController::Blobstore::ClientProvider).to receive(:provide).with(
7979
options: config.get(:resource_pool),
80-
directory_key: 'key'
80+
directory_key: 'key',
81+
resource_type: :resource_pool
8182
)
8283
locator.legacy_global_app_bits_cache
8384
end
@@ -97,7 +98,8 @@
9798
expect(CloudController::Blobstore::ClientProvider).to receive(:provide).with(
9899
options: config.get(:resource_pool),
99100
directory_key: 'key',
100-
root_dir: 'app_bits_cache'
101+
root_dir: 'app_bits_cache',
102+
resource_type: :resource_pool
101103
)
102104
locator.global_app_bits_cache
103105
end

0 commit comments

Comments
 (0)