Optimize based on review

Author: WeiQuan0605

lib/logcache/client.rb

@@ -47,12 +47,13 @@ def container_metrics(source_guid:, start_time:, end_time:, envelope_limit: DEFA
     def with_request_error_handling(source_guid)
       tries ||= 3
       start_time = Time.now
-      time_taken = (Time.now - start_time) * 1000 # convert to milliseconds to get more precise information
-      logger.info("Response time: #{time_taken.round(2)} ms",
+
+      result = yield
+      time_taken_in_ms = ((Time.now - start_time) * 1000).to_i # convert to milliseconds to get more precise information
+      logger.info('logcache.response',
                   { source_id: source_guid,
-                    event: 'log_cache_request',
-                    time_taken_in_ms: time_taken.round(2) })
-      yield
+                    time_taken_in_ms: time_taken_in_ms })
+      result
     rescue StandardError => e
       raise CloudController::Errors::ApiError.new_from_details('ServiceUnavailable', 'Connection to Log Cache timed out') if e.is_a?(GRPC::DeadlineExceeded)
 

spec/logcache/client_spec.rb

@@ -62,11 +62,10 @@ module Logcache
         it 'logs the response time and metadata' do
           client.container_metrics(source_guid: process.guid, envelope_limit: 1000, start_time: 100, end_time: 101)
           expect(mock_logger).to have_received(:info).with(
-            a_string_matching(/Response time: \d+\.\d+ ms/),
+            a_string_matching(/logcache.response/),
             hash_including(
               source_id: process.guid,
-              event: 'log_cache_request',
-              time_taken_in_ms: be_a(Float)
+              time_taken_in_ms: be_a(Integer)
             )
           )
         end