Skip to content

Commit ae68e4b

Browse files
committed
Skip migrations check for backwards compatibility tests
This prevents running into timeouts when your feature branch misses a migration already on main.
1 parent f629077 commit ae68e4b

File tree

3 files changed

+13
-1
lines changed

3 files changed

+13
-1
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
Sequel.migration do
2+
up do
3+
end
4+
down do
5+
end
6+
end

lib/cloud_controller/db.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ def self.add_connection_metrics_extension(db)
8080
end
8181

8282
def self.load_models(db_config, logger)
83+
puts '##### in load_models #####'
8384
db = connect(db_config, logger)
8485
DBMigrator.new(db).wait_for_migrations!
8586

@@ -90,6 +91,7 @@ def self.load_models(db_config, logger)
9091
end
9192

9293
def self.load_models_without_migrations_check(db_config, logger)
94+
puts '##### in load_models_without_migrations_check #####'
9395
connect(db_config, logger)
9496

9597
require 'models'

spec/support/bootstrap/spec_bootstrap.rb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,11 @@ def self.init(recreate_test_tables: true, do_schema_migration: true)
3232
db_resetter.recreate_tables(without_migration: !do_schema_migration)
3333
end
3434

35-
DB.load_models(db_config.config, db_config.db_logger)
35+
if do_schema_migration
36+
DB.load_models(db_config.config, db_config.db_logger)
37+
else
38+
DB.load_models_without_migrations_check(db_config.config, db_config.db_logger)
39+
end
3640
end
3741

3842
def self.seed

0 commit comments

Comments
 (0)