improve mock

Author: johha

spec/unit/lib/delayed_job_plugins/delayed_jobs_metrics_spec.rb

@@ -1,12 +1,12 @@
-require 'db_spec_helper'
+require 'spec_helper'
 
 RSpec.describe DelayedJobMetrics::Plugin do
-  let(:prometheus) { instance_double(VCAP::CloudController::Metrics::PrometheusUpdater) }
   let(:worker) { instance_double(Delayed::Worker, name: 'test_worker') }
 
   before do
-    allow(CloudController::DependencyLocator.instance).to receive(:cc_worker_prometheus_updater).and_return(prometheus)
-    allow(prometheus).to receive(:update_histogram_metric)
+    @prometheus = instance_double(VCAP::CloudController::Metrics::PrometheusUpdater)
+    allow(CloudController::DependencyLocator.instance).to receive(:cc_worker_prometheus_updater).and_return(@prometheus)
+    allow(@prometheus).to receive(:update_histogram_metric)
   end
 
   it 'loads the plugin' do
@@ -25,16 +25,14 @@
       worker = Delayed::Worker.new
       worker.name = 'test_worker'
       worker.work_off(1)
-      # Debug plugins
-      puts "Plugins: #{Delayed::Worker.plugins.inspect}"
 
-      expect(prometheus).to have_received(:update_histogram_metric).with(
+      expect(@prometheus).to have_received(:update_histogram_metric).with(
         :cc_job_pickup_delay_seconds,
         be_within(0.5).of(10.0),
         labels: { queue: VCAP::CloudController::Jobs::Queues.generic, worker: 'test_worker' }
       ).once
 
-      expect(prometheus).to have_received(:update_histogram_metric).with(
+      expect(@prometheus).to have_received(:update_histogram_metric).with(
         :cc_job_duration_seconds,
         kind_of(Numeric),
         labels: { queue: VCAP::CloudController::Jobs::Queues.generic, worker: 'test_worker' }