take AzureRM for consistency

Author: kathap

lib/cloud_controller/blobstore/storage_cli/azure_storage_cli_client.rb

@@ -5,7 +5,7 @@ def cli_path
         ENV['AZURE_STORAGE_CLI_PATH'] || '/var/vcap/packages/azure-storage-cli/bin/azure-storage-cli'
       end
 
-      CloudController::Blobstore::StorageCliClient.register('azure', AzureStorageCliClient)
+      CloudController::Blobstore::StorageCliClient.register('AzureRM', AzureStorageCliClient)
     end
   end
 end

spec/unit/lib/cloud_controller/blobstore/storage_cli/azure_storage_cli_client_spec.rb

@@ -10,7 +10,7 @@ module Blobstore
     RSpec.describe AzureStorageCliClient do
       let!(:tmp_cfg) do
         f = Tempfile.new(['storage_cli_config', '.json'])
-        f.write({ provider: 'azure',
+        f.write({ provider: 'AzureRM',
                   account_name: 'some-account-name',
                   account_key: 'some-access-key',
                   container_name: directory_key,
@@ -82,8 +82,8 @@ module Blobstore
         end
 
         it 'can be overridden by an environment variable' do
-          allow(ENV).to receive(:[]).with('AZURE_STORAGE_CLI_PATH').and_return('/custom/path/to/azure-storage-cli')
-          expect(client.cli_path).to eq('/custom/path/to/azure-storage-cli')
+          allow(ENV).to receive(:[]).with('AZURE_STORAGE_CLI_PATH').and_return('/custom/path/to/AzureRM-storage-cli')
+          expect(client.cli_path).to eq('/custom/path/to/AzureRM-storage-cli')
         end
       end
 

spec/unit/lib/cloud_controller/blobstore/storage_cli/storage_cli_client_spec.rb

@@ -156,8 +156,8 @@ def build_client(resource_type)
 
         it 'raises when provider is missing from config file' do
           File.write(packages_cfg.path, {
-            azure_storage_access_key: 'bommelkey',
-            azure_storage_account_name: 'bommel',
+            AzureRM_storage_access_key: 'bommelkey',
+            AzureRM_storage_account_name: 'bommel',
             container_name: 'bommelcontainer',
             environment: 'BommelCloud'
           }.to_json)